unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philip Kaludercic <philipk@posteo.net>
Cc: chad <yandros@gmail.com>,  EMACS development team <emacs-devel@gnu.org>
Subject: Re: Adding use-package to ELPA
Date: Mon, 07 Mar 2022 16:03:46 -0500	[thread overview]
Message-ID: <jwv8rtllbtl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ilsp4lc8.fsf@posteo.net> (Philip Kaludercic's message of "Mon,  07 Mar 2022 19:24:39 +0000")

> True, because the above examples just expands to
>
>       (setq smtpmail-smtp-service 587)
>
> I'd usually recommend to use a local macro to avoid these issues,
> because something like
>
>       (setup smtpmail
>         (:option smtpmail-smtp-service 587))
>
> would expand to a `customize-set-variable'-like code, where
> `smtpmail-smtp-service' would appear as a quoted symbol.

If it expands to `customize-set-variable`, then presumably you wouldn't
get the warning, indeed (that's good) but you also wouldn't get
a warning if you mistype the var (less good).

I want both: absence of warnings when the var name is right, and
presence of a warning when it isn't (and presence of a warning when the
var is obsolete).

>> So `setup.el` could maybe do something like:
>>
>>     (defmacro setup (pkg &rest args)
>>       (when (we-are-byte-compiling-p)
>>         (require (byte-run-strip-symbol-positions pkg)))
>>       ...)
>
> What is the point of using byte-run-strip-symbol-positions here?

Macros receive source code as input, which can/should come with
source-position information.  Before we can safely run that code we need
to strip the position info.

> I just tried something like this, but it doesn't seem to work.

I'm glad to see that I'm still able to write incorrect code.


        Stefan




  reply	other threads:[~2022-03-07 21:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 11:42 Adding use-package to ELPA Philip Kaludercic
2022-03-05  5:34 ` Richard Stallman
2022-03-05  8:15   ` Philip Kaludercic
2022-03-05 20:27     ` chad
2022-03-06 10:31       ` Philip Kaludercic
2022-03-06 23:06         ` John Wiegley
2022-03-07  0:02           ` Philip Kaludercic
2022-03-07  0:34             ` John Wiegley
2022-03-07  2:29               ` Stefan Monnier
2022-03-07  9:02                 ` Philip Kaludercic
2022-03-07 18:01                 ` Stefan Monnier
2022-03-07 18:42                   ` John Wiegley
2022-03-07 19:24                   ` Philip Kaludercic
2022-03-07 21:03                     ` Stefan Monnier [this message]
2022-03-07 23:12                       ` Philip Kaludercic
2022-03-07 23:40                         ` Stefan Monnier
2022-03-08  8:21                           ` Philip Kaludercic
2022-03-08 14:22                             ` Stefan Monnier
2022-03-06  5:16     ` Richard Stallman
  -- strict thread matches above, loose matches on Subject: below --
2022-03-03 11:41 Philip Kaludercic
2022-03-03 14:49 ` Stefan Monnier
2022-03-04  5:57   ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv8rtllbtl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    --cc=yandros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).