From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: minibuffer-header Date: Sat, 06 Aug 2022 18:03:21 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Nicolas P. Rougier (inria)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 07 00:04:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKRuN-0009Tu-A4 for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 00:04:35 +0200 Original-Received: from localhost ([::1]:57786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKRuL-0004FA-PU for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Aug 2022 18:04:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKRtJ-0002qM-Or for emacs-devel@gnu.org; Sat, 06 Aug 2022 18:03:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKRtH-0003Hv-Bs for emacs-devel@gnu.org; Sat, 06 Aug 2022 18:03:28 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 88DEF4413E2; Sat, 6 Aug 2022 18:03:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1E3B2440A17; Sat, 6 Aug 2022 18:03:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659823405; bh=HDMEOF51AQhYmCbeXlbZV0ztdT9STecobqr8Is4aFkM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=l16VWf1+3fJKr7NWYA4LXmJcKYgOr5fh/O9Bq6GMrr+8UuKWoWVPPs0R9YAGPIIjw ccTyEZJL8U2bzKcx7nuT92LRprUUIk5rssiZBN5MQSXp5aOEp7mk2Wt54c9CIgOTMm aGcUZnEf1g8ZNzCQyNGfqv1imZH0rEg0FHfCbXRyELLPJZH2r/wXQx8xjiEsDusKJ9 kqxzhu9oPBRBy1tibH+QRAd1McTRslfi6ZtTro0V2j1g6Kxq/e6+x2KMfdwaLejnuk FhuVaeq4ocpVmJ6LXxqP3XFLPBcKz3xAF7EOQl09kHOoQG7Rk97PYCKcu24zvORfZ8 6quDDnP7CpiZA== Original-Received: from milanesa (unknown [46.44.221.102]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 758641204A0; Sat, 6 Aug 2022 18:03:24 -0400 (EDT) In-Reply-To: (Nicolas P. Rougier's message of "Sat, 06 Aug 2022 17:59:32 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293161 Archived-At: --=-=-= Content-Type: text/plain Nicolas P. Rougier (inria) [2022-08-06 17:59:32] wrote: > I would like to submit a new package to ELPA which is a minor-mode that > display a header line in the minibuffer (and can optionally display messages > as well). I just added it to elpa.git, but it won't be released into GNU ELPA yet because of the "Copyright" line in the file, which needs to be updated, as in the patch below, which also tweaks the `.gitignore`. After making those changes, you should be able to check the result at https://elpa.gnu.org/devel/minibuffer-header.html Once you're satisfied, you'll need to additionally bump the `Version:` in order to tell GNU ELPA to build a release tarball. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=minibuffer-header.patch diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000000..33b35ed269 --- /dev/null +++ b/.gitignore @@ -0,0 +1,3 @@ +*.elc +/minibuffer-header-autoloads.el +/minibuffer-header-pkg.el diff --git a/minibuffer-header.el b/minibuffer-header.el index b511878710..bdba9b0303 100644 --- a/minibuffer-header.el +++ b/minibuffer-header.el @@ -1,6 +1,6 @@ ;;; minibuffer-header.el --- Minibuffer header line -*- lexical-binding: t -*- -;; Copyright (C) 2022 Nicolas P. Rougier +;; Copyright (C) 2022 Free Software Foundation, Inc. ;; Maintainer: Nicolas P. Rougier ;; URL: https://github.com/rougier/minibuffer-header @@ -173,7 +173,10 @@ 'front-sticky t))))))))) -(defun minibuffer-header--message-override (orig-fun &rest args) +(defun minibuffer-header--message-override (_orig-fun &rest args) + ;; FIXME: Thje arglist looks wrong. It's what I would expect for + ;; an `:around' advice, but not for an `:override' advice, which + ;; does not receive the `orig-fun'. "This advice is used to override the original message function" ;; Debug buffer (since we cannot use message for log) @@ -182,7 +185,7 @@ ;; (insert (format "\n%s" args))) (let* ((msg (if (and (car args) (stringp (car ar --=-=-=--