From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Date: Sun, 29 Jan 2023 21:50:17 -0500 Message-ID: References: <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org> <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Luke Lee Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 03:51:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMKG4-0007rZ-Jn for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 03:51:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMKFV-0008A8-L0; Sun, 29 Jan 2023 21:50:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMKFU-0008A0-Bi for emacs-devel@gnu.org; Sun, 29 Jan 2023 21:50:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMKFS-00032B-Ke for emacs-devel@gnu.org; Sun, 29 Jan 2023 21:50:24 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B4A87441380; Sun, 29 Jan 2023 21:50:20 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7C972441379; Sun, 29 Jan 2023 21:50:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675047019; bh=muVQlP8tb+gsVX/k+9RE2tT9iojgX802TJd5McUx2cQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VMa0cXIhhMYo3NNX5B110h0j/FTf1pFjE/0YJIcZ0SZV/Qd5lEar7DlJWB/Vpveog n5YG4UWb8BOGgAg6TaiBUqqF29eCZjylzejuGNCQhFVwkTK1MLYpDCP6r9O2exEy/Q QhbIEWvG397HxJPbahii3FsWFZ0efgNukQvzfjf6hRCfG3KHcwkWtKk3tERExmQorZ 2XfUmEWyw6HWcbPaXp+WxopeiUu7bkFZ0hIqEObwdKPdhMU0kRTdOmirjlzWT0sfPe 7dNiP6IJ0Ulw2PZnrBxTHm+HLlp+euaaPa/Gr1snwI3isEXLMJNKogkCRIWUldSCJT /PsD9KY/oNJsQ== Original-Received: from pastel (unknown [167.88.21.243]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BA8301224FE; Sun, 29 Jan 2023 21:50:18 -0500 (EST) In-Reply-To: <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> (Luke Lee's message of "Sun, 29 Jan 2023 11:22:13 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302769 Archived-At: > (eval-when-compile > - (require 'cl-lib) > + (if (version< emacs-version "27.0") > + (progn > + (require 'cl) ;; Package cl is deprecated for Emacs27+ > + (require 'cl-macs)) > + (require 'cl-lib)) This looks like a regression resulting from a misunderstanding. What are you trying to do here? The rest of the code only uses `cl-lib` functionality, so (require 'cl) will only be useful because if it internally does (require 'cl-lib). In Emacs<24.3, this will fail because (require 'cl) will not define the macros that the rest of the code needs (e.g. `cl-eval-when`, `cl-loop`, ...). Stefan