Re: pkg-autoloads.el vs. pkg-loaddefs.el

[Stefan Monnier <monnier@iro.umontreal.ca>]

>>> May an approach like `require-with-check' be used here?  Then, the
>>> reloading only occurs when there is a potential mixing of package
>>> versions.
>>
>> Could be, tho I'm not sure exactly what "an approach like
>> `require-with-check`" would look like.
>
> Something like
>
> (defun package-activate-1...
> ...
>
> (let ((autoload-feature (intern (format "%s-autoloads"
>                              (package-desc-name pkg-desc)))))
>   (when (and (featurep autoload-feature)
>              (require-with-check autoload-feature nil 'reload))
>     ;; If pkg-autoload.el is already loaded from a different path,
>     ;; reload the package.
>     (warn ...)
>     (setq reload t)))
>     
> (when reload
>   (package--reload-previously-loaded pkg-desc))
>   
> (with-demoted-errors "Error loading autoloads: %s"
>   (load (package--autoloads-file-name pkg-desc) nil t))

Hmm... I wonder when that `featurep` test would trigger, tho.

E.g. for Org usually the "old already loaded Org" is the one from Emacs
which doesn't come with an `org-autoloads.el`.

As for the case where we've already loaded an older version of an
ELPA package, this requires two versions of the same ELPA package which
is unusual (except during an upgrade, but that case already passes the
`reload` arg).


        Stefan