From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Turning on/off tree-sitter modes Date: Tue, 03 Dec 2024 21:14:36 -0500 Message-ID: References: <566ac897-ea5e-4141-bcb3-306d43c9118a@gutov.dev> <865xohrvfa.fsf@gnu.org> <86wmgwnyle.fsf@gnu.org> <178dfc7f-bc2d-4e3b-8417-a616ccc0eef3@gutov.dev> <86v7wgnxlz.fsf@gnu.org> <01d83ec8-c02b-4806-8764-38dc89a89125@gutov.dev> <86ttbzojho.fsf@gnu.org> <930f5c8e-1481-43a5-8f1d-2c13a98df74f@gutov.dev> <86r072krq5.fsf@gnu.org> <27a62624-387c-4233-b995-170270e26efd@gutov.dev> <86iks245q0.fsf@gnu.org> <86bjxt2avf.fsf@gnu.org> <86wmgg26rt.fsf@gnu.org> <56d7b33e-9b95-48ef-9c6d-c5bd14c824af@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28691"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 03:15:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIevR-0007Jy-GJ for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 03:15:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIeue-0003wB-Dy; Tue, 03 Dec 2024 21:14:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIeub-0003lZ-Qn for emacs-devel@gnu.org; Tue, 03 Dec 2024 21:14:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIeuZ-0005bd-CE; Tue, 03 Dec 2024 21:14:45 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8EB08808D7; Tue, 3 Dec 2024 21:14:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1733278477; bh=FUu3DUAWzDc5yzGs18N+maGTLjMzurHPjvpLVYNrKXU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aQY49k4rMBQroIyg7wRcJ3JPQqXpSc+MW1umMoFD4XMiXUBcN2G8dijKI4GmHBShB 6wYh65Qqkj0JnTaXsfk7YspyIaLHCZ2tMd0afRfL4XTL8BJ3YYTM+HHKh8SDGIBzFs l2mezlO+xIziQOQJYKJcfh8H43UDZy6P1iuTO3eRdnkS6fvnqeEk+beuV+WmOLDWZ2 bmg1gBktwSYbpzz1e7858zc4gBN3e65eL3JFkIK8EDzbMuoKwWjX5hg0dBjCgpnJZy UoJ8GNcf/5VLEHDDjYBWZ/TfoHCsyVL3g3FsBqO5yt6voZjwjZWRDhOiOfAR3auSv6 1LFEXePN1h1IQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 352CF80762; Tue, 3 Dec 2024 21:14:37 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 066FA1202F2; Tue, 3 Dec 2024 21:14:36 -0500 (EST) In-Reply-To: <56d7b33e-9b95-48ef-9c6d-c5bd14c824af@gutov.dev> (Dmitry Gutov's message of "Wed, 4 Dec 2024 03:47:00 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326012 Archived-At: > Take for example rust-ts-mode, or dockerfile-ts-mode: the body of the major > mode function is wrapped in > > (when (treesit-ready-p 'dockerfile) > ... > ) Yeah, I see now that `cmake-ts-mode` does the same. > If there are downsides, they would probably be limited to having the mm > keymap enabled, or dockerfile-ts-mode-hook run, which could be good too - > depending on what the user expects to happen. No, I think using `FOO-ts-mode` is better than `fundamental-mode` anyway, indeed. Stefan