* Re: Changes to emacs/src/xfaces.c,v
[not found] <E1JTH20-0001st-1t@cvs.savannah.gnu.org>
@ 2008-02-26 8:32 ` Glenn Morris
2008-02-26 21:17 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2008-02-26 8:32 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
Stefan Monnier wrote:
> - int next_overlay;
> + EMACS_INT next_overlay;
I'm very ignorant of these matters, but is that change (and the
similar one in xdisp.c:next_overlay_change) correct?
The 5th arg of overlays_at is int, not EMACS_INT. Now I get this
warning when compiling:
xfaces.c:8154: warning: passing argument 5 of 'overlays_at' from
incompatible pointer type
Perhaps you meant to make the first argument `pos' an EMACS_INT, as
the ChangeLog suggests?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Changes to emacs/src/xfaces.c,v
2008-02-26 8:32 ` Changes to emacs/src/xfaces.c,v Glenn Morris
@ 2008-02-26 21:17 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2008-02-26 21:17 UTC (permalink / raw)
To: Glenn Morris; +Cc: Emacs developers
>> - int next_overlay;
>> + EMACS_INT next_overlay;
> I'm very ignorant of these matters, but is that change (and the
> similar one in xdisp.c:next_overlay_change) correct?
Yes. This is necessary for >4GB buffers on 64bit systems (except for
those 64bit systems where `int' is 64bit).
> The 5th arg of overlays_at is int, not EMACS_INT. Now I get this
> warning when compiling:
> xfaces.c:8154: warning: passing argument 5 of 'overlays_at' from
> incompatible pointer type
Fixed, thanks,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-26 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1JTH20-0001st-1t@cvs.savannah.gnu.org>
2008-02-26 8:32 ` Changes to emacs/src/xfaces.c,v Glenn Morris
2008-02-26 21:17 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).