From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: breadcrumbs for Info . . . . . . Date: Sat, 14 Jun 2008 22:04:48 -0400 Message-ID: References: <009d01c8cb55$13d53e20$0200a8c0@us.oracle.com> <87fxrkltma.fsf@jurta.org> <00ae01c8cb71$c26aeef0$0200a8c0@us.oracle.com> <873ankqou6.fsf@jurta.org> <00d901c8cbc9$7df36fb0$0200a8c0@us.oracle.com> <87tzfzk331.fsf@jurta.org> <00a501c8ccdd$93328720$c2b22382@us.oracle.com> <002401c8cd1f$98631650$0200a8c0@us.oracle.com> <004a01c8cd67$b2f7a9c0$0200a8c0@us.oracle.com> <87ve0b5zol.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213495517 30141 80.91.229.12 (15 Jun 2008 02:05:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2008 02:05:17 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 15 04:06:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7hcl-0002xW-5K for ged-emacs-devel@m.gmane.org; Sun, 15 Jun 2008 04:05:52 +0200 Original-Received: from localhost ([127.0.0.1]:56709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7hbx-0003Um-6J for ged-emacs-devel@m.gmane.org; Sat, 14 Jun 2008 22:04:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7hbu-0003Tm-0N for emacs-devel@gnu.org; Sat, 14 Jun 2008 22:04:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7hbt-0003TB-Eo for emacs-devel@gnu.org; Sat, 14 Jun 2008 22:04:49 -0400 Original-Received: from [199.232.76.173] (port=35346 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7hbt-0003T4-Ao for emacs-devel@gnu.org; Sat, 14 Jun 2008 22:04:49 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:43892 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K7hbs-0006Hz-TQ for emacs-devel@gnu.org; Sat, 14 Jun 2008 22:04:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAG8VVEjO+KWv/2dsb2JhbACBW6pZ X-IronPort-AV: E=Sophos;i="4.27,646,1204520400"; d="scan'208";a="22647701" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 14 Jun 2008 22:04:48 -0400 Original-Received: from pastel.home ([206.248.165.175]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id VIT64048; Sat, 14 Jun 2008 22:04:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 274458336; Sat, 14 Jun 2008 22:04:48 -0400 (EDT) In-Reply-To: <87ve0b5zol.fsf@jurta.org> (Juri Linkov's message of "Sun, 15 Jun 2008 03:28:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99240 Archived-At: >>> Attached. >> I installed a reworked version of this. > There is one problem: all breadcrumb links are displayed as visited > even when there are not. The simplest fix is to let-bind variables > Info-history and Info-history-list in Info-insert-breadcrumbs. But > I see Info-find-node is called with `no-going-back'. Maybe code that > adds a new visited node to Info-history-list should be moved from > Info-select-node to Info-find-node-2 and be called conditionally > on no-going-back, but this would be inappropriate semantics for > Info-history-list. So perhaps let-bind is the best fix. Oh, yes, indeed. Info.el's code is terrible in this respect. Could you try and fix this problem, please? Stefan