From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org, dima@sphinx.net.ru,
Kenichi Handa <handa@m17n.org>
Subject: Re: 23.0.60; Assuming errstring unibyte is incorrect and leads to Emacs crashes
Date: Sun, 31 Aug 2008 14:36:46 -0400 [thread overview]
Message-ID: <jwv7i9x58x7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <uk5e316vn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Aug 2008 06:20:12 +0300")
>> + if (! EQ (Faref (errstring, make_number (1)), make_number ('/')))
>> + {
>> + int c;
>> +
>> + str = (char *) SDATA (errstring);
>> + c = STRING_CHAR (str, 0);
>> + Faset (errstring, 0, make_number (DOWNCASE (c)));
>> + }
> Can we explain in a comment what is special about a slash as the
> second character of the error message?
Actually, I think we need an explanation for why we bother to downcase
this thing at all.
Stefan
next prev parent reply other threads:[~2008-08-31 18:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 17:28 23.0.60; Assuming errstring unibyte is incorrect and leads to Emacs crashes Chong Yidong
2008-08-27 1:13 ` Kenichi Handa
2008-08-27 3:20 ` Eli Zaretskii
2008-08-28 0:40 ` Kenichi Handa
2008-08-28 3:20 ` Eli Zaretskii
2008-08-28 5:53 ` Kenichi Handa
2008-08-28 9:23 ` Jason Rumney
2008-08-28 20:43 ` Stephen Berman
2008-08-31 18:36 ` Stefan Monnier [this message]
2008-09-01 6:11 ` Richard M. Stallman
2008-09-01 18:22 ` Stefan Monnier
2008-09-02 1:09 ` Richard M. Stallman
2008-09-02 19:56 ` Stefan Monnier
2008-09-03 2:41 ` Richard M. Stallman
2008-09-03 16:09 ` Stefan Monnier
2008-09-04 0:10 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7i9x58x7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=dima@sphinx.net.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).