From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: new compile.el Date: Wed, 11 Mar 2009 10:46:01 -0400 Message-ID: References: <49B11B93.6070907@synopsys.com> <49B1A6B0.2080308@synopsys.com> <49B66A32.20908@synopsys.com> <49B7BF5D.8090909@synopsys.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236782853 8922 80.91.229.12 (11 Mar 2009 14:47:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 14:47:33 +0000 (UTC) Cc: Emacs Devel To: Reto Zimmermann , Daniel Pfeiffer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 11 15:48:41 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhPjE-0006LS-NH for ged-emacs-devel@m.gmane.org; Wed, 11 Mar 2009 15:48:16 +0100 Original-Received: from localhost ([127.0.0.1]:57430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPht-0002dE-0C for ged-emacs-devel@m.gmane.org; Wed, 11 Mar 2009 10:46:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhPh7-0002Re-1X for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:46:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhPh4-0002QV-I4 for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:46:03 -0400 Original-Received: from [199.232.76.173] (port=57217 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhPh4-0002QQ-Ah for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:46:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:28626) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhPh3-0005LW-Ut for emacs-devel@gnu.org; Wed, 11 Mar 2009 10:46:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlwFAP9rt0lFxL+1/2dsb2JhbACBTs94hA0GhDE X-IronPort-AV: E=Sophos;i="4.38,343,1233550800"; d="scan'208";a="35037291" Original-Received: from 69-196-191-181.dsl.teksavvy.com (HELO pastel.home) ([69.196.191.181]) by ironport2-out.teksavvy.com with ESMTP; 11 Mar 2009 10:46:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3BF758258; Wed, 11 Mar 2009 10:46:01 -0400 (EDT) In-Reply-To: <49B7BF5D.8090909@synopsys.com> (Reto Zimmermann's message of "Wed, 11 Mar 2009 14:40:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109567 Archived-At: >> I'm guessing that you're talking about the error-regexp code that's in >> emacs/lisp/progmodes/vhdl-mode.el. Looking at it, I do not quite >> understand what the code is meant to do: >> vhdl-compile-use-local-error-regexp sets error-regexp-alist in the >> vhdl-mode buffer rather than in the compilation buffer. > Looks like that's the problem. It worked before though. You mean in Emacs-21, right? compile.el hasn't been changed much in Emacs-23, IIRC. Indeed, I now see that Emacs-21's compile.el explicitly copied the error-regexp-alist setting from the calling buffer to the compilation buffer. I guess it might make sense to do that as well in the new compile.el. Daniel, could you look into it? > Now variable compilation-file-regexp-alist also doesn't exist anymore, > so I guess I would have to rewrite the whole compilation section of > vhdl-mode. IIRC you can just place the corresponding entries onto compilation-error-regexp-alist. Stefan