From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: interactive-p and called-interactively-p Date: Sat, 29 Aug 2009 17:54:26 -0400 Message-ID: References: <8AD328622F5645B282D1E72CB4582EF3@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251582888 23152 80.91.229.12 (29 Aug 2009 21:54:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 21:54:48 +0000 (UTC) Cc: drew.adams@oracle.com, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 29 23:54:41 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhVsd-00043y-LI for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 23:54:40 +0200 Original-Received: from localhost ([127.0.0.1]:44372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhVsc-00056z-Um for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 17:54:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhVsY-00054u-38 for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:54:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhVsT-0004xn-3r for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:54:33 -0400 Original-Received: from [199.232.76.173] (port=60382 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhVsS-0004xh-Uu for emacs-devel@gnu.org; Sat, 29 Aug 2009 17:54:28 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:22865 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhVsR-0003QI-LL; Sat, 29 Aug 2009 17:54:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmYFAN8/mUpFpYuS/2dsb2JhbACBU9RfhBoFh2g X-IronPort-AV: E=Sophos;i="4.44,296,1249272000"; d="scan'208";a="44507655" Original-Received: from 69-165-139-146.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.146]) by ironport2-out.teksavvy.com with ESMTP; 29 Aug 2009 17:53:25 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 52FCF7F42; Sat, 29 Aug 2009 17:54:26 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Sun, 16 Aug 2009 17:23:02 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114853 Archived-At: > I object. Two different names makes it easier to remember the > difference. An argument would be harder to remember. I disagree completely: it's a lot easier to notice that the function you use accepts an argument than to notice that there's another function outthere doing something similar yet different. Especially if you use eldoc-mode, of course. > The name `called-interactively-p' is good because > it relates to the use of `interactive'. The name `interactive-p' > is confusing because it does NOT relate. I don't care much which one is kept, but I'd like to remove one of the two. `interactive-p' has the advantage that it existed for a *very* long time, whereas called-interactively-p is a new comer. So even if we obsolete interactive-p now, it'll take many many years before we can actually remove it, whereas called-interactively-p is still almost unused outside of Emacs's bundled packages. > Perhaps we should make the name `interactive-p' obsolete and make > a new name, `from-user-input-p'. This will eliminate the > confusion completely. Even such a new name isn't very clear. The only clear solution is to use an additional argument passed from the interactive spec. So I'd rather not add yet more functions to support this hack (if you look at the implementation of `interactive_p' it's clear that it's a nasty hack). Stefan