From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate): Date: Thu, 08 Apr 2010 23:13:33 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270782826 17291 80.91.229.12 (9 Apr 2010 03:13:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 9 Apr 2010 03:13:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 09 05:13:45 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O04f9-0004v1-23 for ged-emacs-devel@m.gmane.org; Fri, 09 Apr 2010 05:13:43 +0200 Original-Received: from localhost ([127.0.0.1]:57967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O04f8-0004X5-Ct for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 23:13:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O04f3-0004WA-5u for emacs-devel@gnu.org; Thu, 08 Apr 2010 23:13:37 -0400 Original-Received: from [140.186.70.92] (port=54611 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O04f1-0004UW-RZ for emacs-devel@gnu.org; Thu, 08 Apr 2010 23:13:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O04f0-0007a5-Bb for emacs-devel@gnu.org; Thu, 08 Apr 2010 23:13:35 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47727 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O04f0-0007a0-6v; Thu, 08 Apr 2010 23:13:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAKM3vkvO+K6K/2dsb2JhbACbO3K6Y4UJBIs6 X-IronPort-AV: E=Sophos;i="4.52,174,1270440000"; d="scan'208";a="60502156" Original-Received: from 206-248-174-138.dsl.teksavvy.com (HELO pastel.home) ([206.248.174.138]) by ironport2-out.pppoe.ca with ESMTP; 08 Apr 2010 23:13:33 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9F63781AE; Thu, 8 Apr 2010 23:13:33 -0400 (EDT) In-Reply-To: (Sam Steingold's message of "Wed, 7 Apr 2010 16:40:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123372 Archived-At: >> - Please don't autoload defcustoms unless you have a *really* good >> reason to do it (and even then, ask permission first). > I autoloaded this one because its sibling compilation-ask-about-save > is autoloaded. Thanks. So we can remove this ;;;###autoload (sadly, removing it from the other variable is not so easy because we first need to check whether some code somewhere relies on it being autoloaded: that's one of the reason why we don't want to autoload vars, since once it's done, it's difficult to go back). >> - I like where this is going, but I'm not sure this is enough. >> Could you explain how you see it being used? > if you edit a huge file which is expensive to save, you do not want it > to be saved whenever you start a compilation elsewhere. ;-) that part I understand of course. But I mean what value do you expect users to use it with? Would they globally set it to save one particular directory of theirs? What if they have more than one project? Part of the question is because Customize doesn't know how to set/handle defcustoms other than globally. >> Could you also explain why `compilation-directory' can't be >> used instead? > because if you are working on a project foo and compile in directory foo/src, > you do want to save buffers editing foo/headers/baz.h, > but it is not under compilation-directory, which is foo/src/. Can you imagine a way to make it "work automatically", maybe assuming some particular convention that's followed half-often or that would be easy to adjust to? Stefan