unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sam Steingold <sds@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate):
Date: Thu, 08 Apr 2010 23:13:33 -0400	[thread overview]
Message-ID: <jwv7hoh8gqo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <g2r1f77704b1004071340x8ca28d2yfb9b59a57b2f1444@mail.gmail.com> (Sam Steingold's message of "Wed, 7 Apr 2010 16:40:27 -0400")

>> - Please don't autoload defcustoms unless you have a *really* good
>> reason to do it (and even then, ask permission first).
> I autoloaded this one because its sibling compilation-ask-about-save
> is autoloaded.

Thanks.  So we can remove this ;;;###autoload (sadly, removing it from
the other variable is not so easy because we first need to check
whether some code somewhere relies on it being autoloaded: that's one of
the reason why we don't want to autoload vars, since once it's done,
it's difficult to go back).

>> - I like where this is going, but I'm not sure this is enough.
>> Could you explain how you see it being used?
> if you edit a huge file which is expensive to save, you do not want it
> to be saved whenever you start a compilation elsewhere.

;-) that part I understand of course.
But I mean what value do you expect users to use it with?
Would they globally set it to save one particular directory of theirs?
What if they have more than one project?
Part of the question is because Customize doesn't know how to set/handle
defcustoms other than globally.

>> Could you also explain why `compilation-directory' can't be
>> used instead?
> because if you are working on a project foo and compile in directory foo/src,
> you do want to save buffers editing foo/headers/baz.h,
> but it is not under compilation-directory, which is foo/src/.

Can you imagine a way to make it "work automatically", maybe assuming
some particular convention that's followed half-often or that would be
easy to adjust to?


        Stefan




  reply	other threads:[~2010-04-09  3:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1NzYsW-0004b6-Iu@internal.in.savannah.gnu.org>
2010-04-07 19:00 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate): New custom variable Stefan Monnier
2010-04-07 20:40   ` Sam Steingold
2010-04-09  3:13     ` Stefan Monnier [this message]
2010-04-09 16:18       ` [Emacs-diffs] /srv/bzr/emacs/trunk r99848: (compilation-save-buffers-predicate): Sam Steingold
2010-04-10  1:04         ` Stefan Monnier
2010-04-11 19:21           ` Sam Steingold
2010-04-11 20:28             ` Stefan Monnier
2010-04-12 20:02               ` Sam Steingold
2010-04-12 21:15                 ` Stefan Monnier
2010-04-12 21:47                   ` Sam Steingold
2010-04-13  0:04                     ` Stefan Monnier
2010-04-13 17:07               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7hoh8gqo.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).