unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Ted Zlatanov <tzz@lifelogs.com>, emacs-devel@gnu.org
Subject: Re: `C-h v' may offer too many symbols
Date: Thu, 10 Mar 2011 21:10:35 -0500	[thread overview]
Message-ID: <jwv7hc6e7dg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTikQ30y3e1iewy+xbdVLDBNoSztWEyJy482zGfPF@mail.gmail.com> (Juanma Barranquero's message of "Thu, 10 Mar 2011 20:39:48 +0100")

> Yes, it is a bit silly complete keywords, which are not variables by
> definition.  I'm going to install this trivial fix.

Sounds good.  FWIW, here's a patch I have pending for the lexbind branch
(where special-variable-p is t only for vars that have been defvar'd
or defconst'd).


        Stefan


=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el	2011-03-06 21:22:16 +0000
+++ lisp/help-fns.el	2011-03-11 02:07:37 +0000
@@ -618,8 +618,8 @@
 				     "Describe variable (default %s): " v)
 				  "Describe variable: ")
 				obarray
-				'(lambda (vv)
-				   (or (boundp vv)
+				(lambda (vv)
+                                  (or (special-variable-p vv)
 				       (get vv 'variable-documentation)))
 				t nil nil
 				(if (symbolp v) (symbol-name v))))




  reply	other threads:[~2011-03-11  2:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 18:52 `C-h v' may offer too many symbols Ted Zlatanov
2011-03-10 19:39 ` Juanma Barranquero
2011-03-11  2:10   ` Stefan Monnier [this message]
2011-03-11  2:27     ` Juanma Barranquero
2011-03-11  4:29       ` Stefan Monnier
2011-03-11  4:31     ` public APIs and private ones (Re: `C-h v' may offer too many symbols) Kenichi Handa
2011-03-11  5:41       ` public APIs and private ones (Re: `C-h v' may offer too manysymbols) Drew Adams
2011-03-11 19:08       ` public APIs and private ones (Re: `C-h v' may offer too many symbols) Ted Zlatanov
2011-03-11 20:28       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7hc6e7dg.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).