From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Move sha1 to C? Date: Sun, 22 May 2011 22:23:55 -0300 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306113848 10619 80.91.229.12 (23 May 2011 01:24:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 May 2011 01:24:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 23 03:24:04 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QOJsK-0005Bt-7Y for ged-emacs-devel@m.gmane.org; Mon, 23 May 2011 03:24:04 +0200 Original-Received: from localhost ([::1]:60168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOJsI-0003Qx-Sm for ged-emacs-devel@m.gmane.org; Sun, 22 May 2011 21:24:02 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOJsG-0003Qh-41 for emacs-devel@gnu.org; Sun, 22 May 2011 21:24:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOJsF-0001Uk-47 for emacs-devel@gnu.org; Sun, 22 May 2011 21:24:00 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:40885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOJsF-0001Uf-1K for emacs-devel@gnu.org; Sun, 22 May 2011 21:23:59 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:44525 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QOJsE-0006VA-KY; Sun, 22 May 2011 21:23:58 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 24CCB66131; Sun, 22 May 2011 22:23:55 -0300 (ART) In-Reply-To: (Leo's message of "Mon, 23 May 2011 04:02:04 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139632 Archived-At: > Do you mind if I do the following: > 1. add sha1.[ch] from gnulib > 2. export sha1 to elisp > 3. obsolete sha1.el Fine by me. 3 should also include "gut sha1.el's content" so that loading it won't end up overwriting the C implementation with the old Elisp code. > Should the signature of sha1 stay as is or change to be similar to md5? > (md5 OBJECT &optional START END CODING-SYSTEM NOERROR) I don't have any opinion on this. The only thing I consider important is to signal an error if the hashed text contains any non-byte character. Stefan