* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module [not found] ` <jwv8v59dmlj.fsf-monnier+emacs@gnu.org> @ 2013-03-28 8:18 ` Aidan Gauland 2013-03-28 10:19 ` Michael Albinus 2013-03-28 13:16 ` [Emacs-diffs] " Stefan Monnier 0 siblings, 2 replies; 14+ messages in thread From: Aidan Gauland @ 2013-03-28 8:18 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-diffs, emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > So IIUC the way it's enabled is by loading the package and then calling > eshell-tramp-initialize. I think the modules' `initialize' functions are called by whatever part of Eshell loads the modules, but I'm not certain. This is one of the yet-to-be-documented parts of Eshell. > This said, IIUC just loading eshell-tramp.el will also enable it (tho > not "completely"). That's a problem (and yes, this is not a new > problem, it's just a problem in most/all eshell modules). Yes, if the feature `em-tramp' is loaded but the module is not enabled, then it is just taking up memory and doing nothing. And, yes, this is a problem with Eshell modules in general, and ERC modules, from what I can tell. I really have no idea what a better solution would be. (I CC'd this message to emacs-devel, because it seems more general now and less about one particular commit.) --Aidan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 8:18 ` /srv/bzr/emacs/trunk r112148: Added eshell-tramp module Aidan Gauland @ 2013-03-28 10:19 ` Michael Albinus 2013-03-28 20:00 ` Aidan Gauland 2013-03-28 13:16 ` [Emacs-diffs] " Stefan Monnier 1 sibling, 1 reply; 14+ messages in thread From: Michael Albinus @ 2013-03-28 10:19 UTC (permalink / raw) To: Aidan Gauland; +Cc: emacs-devel, emacs-diffs Aidan Gauland <aidalgol@no8wireless.co.nz> writes: Hi Aidan, > (I CC'd this message to emacs-devel, because it seems more general now > and less about one particular commit.) Beside the discussion, I believe your commit is also worth a ChangeLog entry and some few words in /etc/NEWS. > --Aidan Best regards, Michael. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 10:19 ` Michael Albinus @ 2013-03-28 20:00 ` Aidan Gauland 2013-03-28 20:23 ` Eli Zaretskii 2013-03-28 21:01 ` Michael Albinus 0 siblings, 2 replies; 14+ messages in thread From: Aidan Gauland @ 2013-03-28 20:00 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel, Stefan Monnier, emacs-diffs Michael Albinus <michael.albinus@gmx.de> writes: > > Beside the discussion, I believe your commit is also worth a ChangeLog > entry and some few words in /etc/NEWS. I did commit with a ChangeLog entry, but not anything to NEWS. What's the policy regarding when to mention a change in NEWS? --Aidan (Sorry for the duplicate; I forgot to include the CC header.) ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 20:00 ` Aidan Gauland @ 2013-03-28 20:23 ` Eli Zaretskii 2013-03-28 22:02 ` Aidan Gauland 2013-03-28 21:01 ` Michael Albinus 1 sibling, 1 reply; 14+ messages in thread From: Eli Zaretskii @ 2013-03-28 20:23 UTC (permalink / raw) To: Aidan Gauland; +Cc: michael.albinus, monnier, emacs-diffs, emacs-devel > From: Aidan Gauland <aidalgol@no8wireless.co.nz> > Date: Fri, 29 Mar 2013 09:00:58 +1300 > Cc: emacs-devel@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>, > emacs-diffs@gnu.org > > What's the policy regarding when to mention a change in NEWS? When it is something users will want to know about. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 20:23 ` Eli Zaretskii @ 2013-03-28 22:02 ` Aidan Gauland 2013-03-29 5:38 ` Eli Zaretskii 0 siblings, 1 reply; 14+ messages in thread From: Aidan Gauland @ 2013-03-28 22:02 UTC (permalink / raw) To: Eli Zaretskii; +Cc: michael.albinus, emacs-diffs, emacs-devel Eli Zaretskii <eliz@gnu.org> writes: >> What's the policy regarding when to mention a change in NEWS? > > When it is something users will want to know about. OK, now in which section should I mention this change? "Changes in Emacs" or "Changes in Specialized Modes and Packages"? And for which version? 24.4? --Aidan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 22:02 ` Aidan Gauland @ 2013-03-29 5:38 ` Eli Zaretskii 0 siblings, 0 replies; 14+ messages in thread From: Eli Zaretskii @ 2013-03-29 5:38 UTC (permalink / raw) To: Aidan Gauland; +Cc: michael.albinus, monnier, emacs-diffs, emacs-devel > From: Aidan Gauland <aidalgol@no8wireless.co.nz> > Cc: michael.albinus@gmx.de, emacs-devel@gnu.org, monnier@iro.umontreal.ca, emacs-diffs@gnu.org > Date: Fri, 29 Mar 2013 11:02:12 +1300 > > Eli Zaretskii <eliz@gnu.org> writes: > > >> What's the policy regarding when to mention a change in NEWS? > > > > When it is something users will want to know about. > > OK, now in which section should I mention this change? "Changes in > Emacs" or "Changes in Specialized Modes and Packages"? I understand that this is a change in Eshell, so the latter seems appropriate. "Changes in Emacs" is for changes in core functionality. > And for which version? 24.4? Yes. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 20:00 ` Aidan Gauland 2013-03-28 20:23 ` Eli Zaretskii @ 2013-03-28 21:01 ` Michael Albinus 2013-03-28 21:52 ` Aidan Gauland 1 sibling, 1 reply; 14+ messages in thread From: Michael Albinus @ 2013-03-28 21:01 UTC (permalink / raw) To: Aidan Gauland; +Cc: emacs-diffs, Stefan Monnier, emacs-devel Aidan Gauland <aidalgol@no8wireless.co.nz> writes: > I did commit with a ChangeLog entry I don't see it. Best regards, Michael. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 21:01 ` Michael Albinus @ 2013-03-28 21:52 ` Aidan Gauland 2013-03-29 8:28 ` Michael Albinus 0 siblings, 1 reply; 14+ messages in thread From: Aidan Gauland @ 2013-03-28 21:52 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-diffs, emacs-devel Michael Albinus <michael.albinus@gmx.de> writes: > Aidan Gauland <aidalgol@no8wireless.co.nz> writes: > >> I did commit with a ChangeLog entry > > I don't see it. $ bzr diff -c 112148 ChangeLog === modified file 'ChangeLog' --- ChangeLog 2013-03-25 17:58:35 +0000 +++ ChangeLog 2013-03-26 22:08:58 +0000 @@ -1,3 +1,13 @@ +2013-03-27 Aidan Gauland <aidalgol@no8wireless.co.nz + + * lisp/eshell/em-unix.el: Moved su and sudo to... + * lisp/eshell/em-tramp.el: ...Eshell tramp module + * doc/misc/eshell.texi: Updated manual to reflect changes. + + External su and sudo commands are now the default; the internal, + TRAMP-using variants can still be used by enabling the eshell-tramp + module. + 2013-03-25 Jan Djärv <jan.h.d@swipnet.se> * configure.ac (HAVE_XKB): Define if Xkb is present. _______________________________________________ Emacs-diffs mailing list Emacs-diffs@gnu.org https://lists.gnu.org/mailman/listinfo/emacs-diffs ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 21:52 ` Aidan Gauland @ 2013-03-29 8:28 ` Michael Albinus 0 siblings, 0 replies; 14+ messages in thread From: Michael Albinus @ 2013-03-29 8:28 UTC (permalink / raw) To: Aidan Gauland; +Cc: emacs-diffs, Stefan Monnier, emacs-devel Aidan Gauland <aidalgol@no8wireless.co.nz> writes: > $ bzr diff -c 112148 ChangeLog Ahh, you made it top-level. Lisp changes are documented in lisp/ChangeLog; could you, please, move the entry there? Same for the change in etc/NEWS; this shall be mentioned in etc/ChangeLog. Best regards, Michael. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 8:18 ` /srv/bzr/emacs/trunk r112148: Added eshell-tramp module Aidan Gauland 2013-03-28 10:19 ` Michael Albinus @ 2013-03-28 13:16 ` Stefan Monnier 2013-03-28 20:03 ` Aidan Gauland [not found] ` <87wqsrnvsh.fsf@dimension8.tehua.net> 1 sibling, 2 replies; 14+ messages in thread From: Stefan Monnier @ 2013-03-28 13:16 UTC (permalink / raw) To: Aidan Gauland; +Cc: emacs-diffs, emacs-devel >> This said, IIUC just loading eshell-tramp.el will also enable it (tho >> not "completely"). That's a problem (and yes, this is not a new >> problem, it's just a problem in most/all eshell modules). > Yes, if the feature `em-tramp' is loaded but the module is not enabled, > then it is just taking up memory and doing nothing. Just taking up memory is not a problem. But IIUC since it defines eshell/su, it will have an impact on eshell buffers, even if eshell-tramp-initialize is not called, right? Stefan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-28 13:16 ` [Emacs-diffs] " Stefan Monnier @ 2013-03-28 20:03 ` Aidan Gauland [not found] ` <87wqsrnvsh.fsf@dimension8.tehua.net> 1 sibling, 0 replies; 14+ messages in thread From: Aidan Gauland @ 2013-03-28 20:03 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-diffs, emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >>> This said, IIUC just loading eshell-tramp.el will also enable it (tho >>> not "completely"). That's a problem (and yes, this is not a new >>> problem, it's just a problem in most/all eshell modules). >> Yes, if the feature `em-tramp' is loaded but the module is not enabled, >> then it is just taking up memory and doing nothing. > > Just taking up memory is not a problem. But IIUC since it defines > eshell/su, it will have an impact on eshell buffers, even if > eshell-tramp-initialize is not called, right? Oh, no, that won't be a problem, because eshell-tramp-initialize has to be called (for each buffer) to register the functions. em-tramp.el line 51: (make-local-variable 'eshell-complex-commands) (setq eshell-complex-commands (append '("su" "sudo") eshell-complex-commands)) So if the module is enabled (and loaded, of course), and you disable it and then create a new eshell buffer, running the commands su and sudo will invoke the external commands, not the internal eshell/su and eshell/sudo. --Aidan (Sorry for the duplicate; I keep hitting R instead of F in Gnus.) ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <87wqsrnvsh.fsf@dimension8.tehua.net>]
[parent not found: <jwvfvzfdytf.fsf-monnier+emacs@gnu.org>]
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112148: Added eshell-tramp module [not found] ` <jwvfvzfdytf.fsf-monnier+emacs@gnu.org> @ 2013-03-29 0:09 ` Aidan Gauland 2013-03-29 20:30 ` Stefan Monnier 0 siblings, 1 reply; 14+ messages in thread From: Aidan Gauland @ 2013-03-29 0:09 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-diffs, emacs-devel Stefan Monnier <monnier@IRO.UMontreal.CA> writes: >> Oh, no, that won't be a problem, because eshell-tramp-initialize has to >> be called (for each buffer) to register the functions. > >> em-tramp.el line 51: > >> (make-local-variable 'eshell-complex-commands) >> (setq eshell-complex-commands >> (append '("su" "sudo") >> eshell-complex-commands)) > >> So if the module is enabled (and loaded, of course), and you disable it >> and then create a new eshell buffer, running the commands su and sudo >> will invoke the external commands, not the internal eshell/su and >> eshell/sudo. > > That's not my experience. > After > M-: (defun eshell/cat (&rest args) (debug)) RET > doing "cat ~/.cvsrc" does not show me ~/.cvsrc but jumps into the > debugger, even though I have not touched eshell-complex-commands. That would be because eshell/cat is already registered by em-unix --Aidan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-29 0:09 ` [Emacs-diffs] " Aidan Gauland @ 2013-03-29 20:30 ` Stefan Monnier 2013-03-30 3:14 ` Aidan Gauland 0 siblings, 1 reply; 14+ messages in thread From: Stefan Monnier @ 2013-03-29 20:30 UTC (permalink / raw) To: Aidan Gauland; +Cc: emacs-diffs, emacs-devel >> That's not my experience. >> After >> M-: (defun eshell/cat (&rest args) (debug)) RET >> doing "cat ~/.cvsrc" does not show me ~/.cvsrc but jumps into the >> debugger, even though I have not touched eshell-complex-commands. > That would be because eshell/cat is already registered by em-unix I tried again with `partx' instead of `cat' and got the same result, yet `partx' does not appear in eshell's source code. Stefan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112148: Added eshell-tramp module 2013-03-29 20:30 ` Stefan Monnier @ 2013-03-30 3:14 ` Aidan Gauland 0 siblings, 0 replies; 14+ messages in thread From: Aidan Gauland @ 2013-03-30 3:14 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-diffs, emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >>> That's not my experience. >>> After >>> M-: (defun eshell/cat (&rest args) (debug)) RET >>> doing "cat ~/.cvsrc" does not show me ~/.cvsrc but jumps into the >>> debugger, even though I have not touched eshell-complex-commands. >> That would be because eshell/cat is already registered by em-unix > > I tried again with `partx' instead of `cat' and got the same result, yet > `partx' does not appear in eshell's source code. Oh... this is a problem, indeed. I'll draw John Wiegley's attention to this thread, and hopefully he can explain this. I *thought* I knew how this part of Eshell worked. :/ --Aidan ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-03-30 3:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1UKcBA-00086f-PW@vcs.savannah.gnu.org>
[not found] ` <jwvip4dfxbh.fsf-monnier+emacs@gnu.org>
[not found] ` <87wqst2vw3.fsf@no8wireless.co.nz>
[not found] ` <jwv8v59dmlj.fsf-monnier+emacs@gnu.org>
2013-03-28 8:18 ` /srv/bzr/emacs/trunk r112148: Added eshell-tramp module Aidan Gauland
2013-03-28 10:19 ` Michael Albinus
2013-03-28 20:00 ` Aidan Gauland
2013-03-28 20:23 ` Eli Zaretskii
2013-03-28 22:02 ` Aidan Gauland
2013-03-29 5:38 ` Eli Zaretskii
2013-03-28 21:01 ` Michael Albinus
2013-03-28 21:52 ` Aidan Gauland
2013-03-29 8:28 ` Michael Albinus
2013-03-28 13:16 ` [Emacs-diffs] " Stefan Monnier
2013-03-28 20:03 ` Aidan Gauland
[not found] ` <87wqsrnvsh.fsf@dimension8.tehua.net>
[not found] ` <jwvfvzfdytf.fsf-monnier+emacs@gnu.org>
2013-03-29 0:09 ` [Emacs-diffs] " Aidan Gauland
2013-03-29 20:30 ` Stefan Monnier
2013-03-30 3:14 ` Aidan Gauland
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).