From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: Sebastian Wiesner <lunaryorn@gmail.com>,
Klaus-Dieter Bauer <bauer.klaus.dieter@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Can the byte-compiler check whether functions passed by name are defined?
Date: Wed, 07 Aug 2013 21:25:45 -0400 [thread overview]
Message-ID: <jwv7gfx0yd7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <mp7gfx40xx.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 07 Aug 2013 17:59:22 -0400")
> (defun foo (&rest args) t)
> (defun foo2 () (mapcar #'foo '(1 2 3)))
[...]
> foo.el:6:1:Warning: the function `foo' is not known to be defined.
> (defun foo () #'assoc-ignore-case)
[...]
> foo.el:1:8:Warning: `function' is an obsolete variable.
The patch below should fix them, indeed, thanks.
Stefan
=== modified file 'lisp/emacs-lisp/bytecomp.el'
--- lisp/emacs-lisp/bytecomp.el 2013-08-07 17:33:30 +0000
+++ lisp/emacs-lisp/bytecomp.el 2013-08-08 01:23:52 +0000
@@ -3574,12 +3574,12 @@
(when (and (symbolp f)
(byte-compile-warning-enabled-p 'callargs))
(when (get f 'byte-obsolete-info)
- (byte-compile-warn-obsolete (car form)))
+ (byte-compile-warn-obsolete f))
;; Check to see if the function will be available at runtime
;; and/or remember its arity if it's unknown.
(or (and (or (fboundp f) ; Might be a subr or autoload.
- (byte-compile-fdefinition (car form) nil))
+ (byte-compile-fdefinition f nil))
(not (memq f byte-compile-noruntime-functions)))
(eq f byte-compile-current-form) ; ## This doesn't work
; with recursion.
next prev parent reply other threads:[~2013-08-08 1:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 10:35 Can the byte-compiler check whether functions passed by name are defined? Klaus-Dieter Bauer
2013-07-29 15:21 ` Stefan Monnier
2013-07-31 13:44 ` Klaus-Dieter Bauer
2013-07-31 17:49 ` Stefan Monnier
2013-07-31 18:01 ` Sebastian Wiesner
2013-08-01 20:31 ` Stefan Monnier
2013-08-04 18:41 ` Klaus-Dieter Bauer
2013-08-04 21:11 ` Stefan Monnier
2013-08-05 8:52 ` Klaus-Dieter Bauer
2013-08-05 14:35 ` Stefan Monnier
2013-08-05 18:17 ` Klaus-Dieter Bauer
2013-08-07 11:27 ` Klaus-Dieter Bauer
2013-08-07 14:41 ` Stefan Monnier
2013-08-07 15:11 ` Klaus-Dieter Bauer
2013-08-07 15:21 ` Stefan Monnier
2013-08-07 17:34 ` Stefan Monnier
2013-08-07 21:11 ` Glenn Morris
2013-08-07 21:59 ` Glenn Morris
2013-08-08 1:25 ` Stefan Monnier [this message]
2013-08-08 8:44 ` Klaus-Dieter Bauer
2013-08-08 13:07 ` Stefan Monnier
2013-08-07 19:59 ` Klaus-Dieter Bauer
2013-08-07 21:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7gfx0yd7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bauer.klaus.dieter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=lunaryorn@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).