From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Severe lossage from unread-command-events Date: Fri, 07 Aug 2015 12:08:44 -0400 Message-ID: References: <87egjh4u1h.fsf@fencepost.gnu.org> <83pp30sd5l.fsf@gnu.org> <87k2t831gf.fsf@fencepost.gnu.org> <83io8ssakw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438963751 322 80.91.229.3 (7 Aug 2015 16:09:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Aug 2015 16:09:11 +0000 (UTC) Cc: David Kastrup , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 07 18:09:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZNkCX-0008Il-7D for ged-emacs-devel@m.gmane.org; Fri, 07 Aug 2015 18:08:57 +0200 Original-Received: from localhost ([::1]:49852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNkCW-0003y7-Fy for ged-emacs-devel@m.gmane.org; Fri, 07 Aug 2015 12:08:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNkCS-0003xo-AC for emacs-devel@gnu.org; Fri, 07 Aug 2015 12:08:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNkCR-000098-G3 for emacs-devel@gnu.org; Fri, 07 Aug 2015 12:08:52 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:14484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNkCL-00007I-4b; Fri, 07 Aug 2015 12:08:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A+FgA731xV//gFNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIxALNBIUGA0kiDcIzyMBAQEBBgIBH4s6hQUHhC0FnxeGaYsrg1kjhBQigngBAQE X-IPAS-Result: A0A+FgA731xV//gFNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIxALNBIUGA0kiDcIzyMBAQEBBgIBH4s6hQUHhC0FnxeGaYsrg1kjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="159090965" Original-Received: from 157-52-5-248.cpe.teksavvy.com (HELO pastel.home) ([157.52.5.248]) by ironport2-out.teksavvy.com with ESMTP; 07 Aug 2015 12:08:44 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 50FF461710; Fri, 7 Aug 2015 12:08:44 -0400 (EDT) In-Reply-To: <83io8ssakw.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Aug 2015 18:25:35 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188565 Archived-At: >> An element of the form (t . EVENT) forces EVENT to be added to that list. > This talks about a different kind of "recording", the one that stores > keyboard input in this-command-keys. My changes don't touch that (at > least I hope they don't ;-) I'm not sure it's really unrelated. The issue is that we don't want events to be recorded twice if you "replay" them (i.e. do something along the lines of (push (read-event) unread-command-events)). >> The code in keyboard.c is complex to a degree where I do not trust >> myself to venture a guess regarding the nature of the right fix. This applies to everyone else as well :-( > > recording. Quite the nuisance. So I'll remove the t thing again and > > will see how I fare then. I think you need to use "the t thing" since your events aren't replays. Stefan