unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: David Kastrup <dak@gnu.org>, emacs-devel@gnu.org
Subject: Re: Severe lossage from unread-command-events
Date: Fri, 07 Aug 2015 12:08:44 -0400	[thread overview]
Message-ID: <jwv7fp7ozmp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83io8ssakw.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Aug 2015 18:25:35 +0300")

>> An element of the form (t . EVENT) forces EVENT to be added to that list.
> This talks about a different kind of "recording", the one that stores
> keyboard input in this-command-keys.  My changes don't touch that (at
> least I hope they don't ;-)

I'm not sure it's really unrelated.  The issue is that we don't want
events to be recorded twice if you "replay" them (i.e. do something
along the lines of (push (read-event) unread-command-events)).

>> The code in keyboard.c is complex to a degree where I do not trust
>> myself to venture a guess regarding the nature of the right fix.

This applies to everyone else as well :-(

> > recording.  Quite the nuisance.  So  I'll remove the t thing again and
> > will see how I fare then.

I think you need to use "the t thing" since your events aren't replays.


        Stefan



  parent reply	other threads:[~2015-08-07 16:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 15:46 Severe lossage from unread-command-events David Kastrup
2015-08-06 14:29 ` Eli Zaretskii
2015-08-06 15:01   ` David Kastrup
2015-08-06 15:25     ` Eli Zaretskii
2015-08-06 15:46       ` David Kastrup
2015-08-06 16:21         ` Eli Zaretskii
2015-08-07 16:08       ` Stefan Monnier [this message]
2015-08-07 16:41         ` David Kastrup
2015-08-08 15:14           ` raman
2015-08-07 18:13         ` Eli Zaretskii
2015-08-06 15:33     ` David Kastrup
2015-08-06 16:10       ` Eli Zaretskii
2015-08-06 16:16         ` David Kastrup
2015-08-06 18:47     ` David Kastrup
2015-08-06 20:00       ` David Kastrup
2015-08-10 16:56         ` David Kastrup
2015-08-10 17:35           ` Eli Zaretskii
2015-08-10 17:47             ` David Kastrup
2015-08-10 18:17               ` Eli Zaretskii
2015-08-10 18:34                 ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7fp7ozmp.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dak@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).