From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: Re: [Emacs-diffs] master 9c4e309: Check that variable lists are actually lists
Date: Thu, 19 Jan 2017 11:40:16 -0500 [thread overview]
Message-ID: <jwv7f5ratxv.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170119161943.49263220159@vcs.savannah.gnu.org> (Philipp Stephani's message of "Thu, 19 Jan 2017 16:19:43 +0000 (UTC)")
> 'let' and 'let*' document that their first argument has to be a list,
> but don't check for that; instead, they allow (and silently ignore)
> other types. Introduce an explicit type check.
Notice that this may end up breaking currently working code :-(
The way we've generally handled such issues is basically that if the
programmer wants sanity checks, he should byte-compile his code.
This has two corollaries:
- We should make sure that the *byte-compiler* does warn about
ill-formed code (we currently don't do a great job of that).
- The interpreter can do whatever it wants with ill-formed code and
doesn't need to go out of its way to detect it.
Stefan
parent reply other threads:[~2017-01-19 16:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170119161943.49263220159@vcs.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7f5ratxv.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).