unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
       [not found] ` <20180519034014.37DF720468@vcs0.savannah.gnu.org>
@ 2018-05-19 18:57   ` Stefan Monnier
  2018-05-20  3:10     ` Tino Calancha
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2018-05-19 18:57 UTC (permalink / raw)
  To: Tino Calancha; +Cc: emacs-devel

> +;;; gited-ci.el --- Obtain CI status of the trunk branch  -*- lexical-binding:t -*-
> +;;

This is missing the copyright and licence blurbs.

> +(defcustom gited-show-trunk-ci-status nil
> +  "Show CI status for the last commit in the trunk branch.
> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ).

I usually prefer to say

    ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ...

So you don't need to talk about the "_I" thingy.

But other than this mostly irrelevant nitpick, I have a more serious
comment to make: why not rely on dir-locals variable for that?


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
  2018-05-19 18:57   ` [elpa] master cfa7c4e: Add missing file gited-ci.el Stefan Monnier
@ 2018-05-20  3:10     ` Tino Calancha
  2018-05-20 13:38       ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Tino Calancha @ 2018-05-20  3:10 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel, Tino Calancha



On Sat, 19 May 2018, Stefan Monnier wrote:

>> +;;; gited-ci.el --- Obtain CI status of the trunk branch  -*- lexical-binding:t -*-
>> +;;
>
> This is missing the copyright and licence blurbs.
Fixed in commit 'gited-ci.el: Fix copyright stuff'

(228610373722e05776b2af8a03064c6a56f04e2c)
>
>> +(defcustom gited-show-trunk-ci-status nil
>> +  "Show CI status for the last commit in the trunk branch.
>> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ).
>
> I usually prefer to say
>
>    ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ...
>
> So you don't need to talk about the "_I" thingy.
Excellent tip! I always suffer such enumerations.  Much better now.
> But other than this mostly irrelevant nitpick, I have a more serious
> comment to make: why not rely on dir-locals variable for that?
Never used dir-locals before.  I need to study such stuff first :-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
  2018-05-20  3:10     ` Tino Calancha
@ 2018-05-20 13:38       ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2018-05-20 13:38 UTC (permalink / raw)
  To: Tino Calancha; +Cc: emacs-devel

>> This is missing the copyright and licence blurbs.
> Fixed in commit 'gited-ci.el: Fix copyright stuff'

Thanks.  I hadn't noticed that the blurb was just further down, sorry.

>> But other than this mostly irrelevant nitpick, I have a more serious
>> comment to make: why not rely on dir-locals variable for that?
> Never used dir-locals before.  I need to study such stuff first :-)

Another option is to store this data inside the .git/config
(i.e. either use Emacs's standard way to set variables per-directory or
use Git's way to do the same per-repository).


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-20 13:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180519034013.18440.57172@vcs0.savannah.gnu.org>
     [not found] ` <20180519034014.37DF720468@vcs0.savannah.gnu.org>
2018-05-19 18:57   ` [elpa] master cfa7c4e: Add missing file gited-ci.el Stefan Monnier
2018-05-20  3:10     ` Tino Calancha
2018-05-20 13:38       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).