From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: BUFFER_SWITCH_EVENT Date: Tue, 25 Sep 2018 17:50:21 -0400 Message-ID: References: <87sh1y535s.fsf@web.de> <8336tyc1ou.fsf@gnu.org> <87mus64wwr.fsf@web.de> <831s9hafl7.fsf@gnu.org> <83wor98t2o.fsf@gnu.org> <83va6t8rts.fsf@gnu.org> <83tvmd8p0z.fsf@gnu.org> <83pnx18kjc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537912152 1792 195.159.176.226 (25 Sep 2018 21:49:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Sep 2018 21:49:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 25 23:49:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4vCd-0000JL-7t for ged-emacs-devel@m.gmane.org; Tue, 25 Sep 2018 23:49:07 +0200 Original-Received: from localhost ([::1]:55383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4vEj-0004fI-Le for ged-emacs-devel@m.gmane.org; Tue, 25 Sep 2018 17:51:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4vDz-0004cR-IR for emacs-devel@gnu.org; Tue, 25 Sep 2018 17:50:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4vDu-0002Za-Je for emacs-devel@gnu.org; Tue, 25 Sep 2018 17:50:30 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:36506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4vDt-0002YS-5l; Tue, 25 Sep 2018 17:50:25 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w8PLoMtv015000; Tue, 25 Sep 2018 17:50:22 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DE0736A682; Tue, 25 Sep 2018 17:50:21 -0400 (EDT) In-Reply-To: <83pnx18kjc.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Sep 2018 22:05:43 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6381=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6381> : inlines <6897> : streams <1799510> : uri <2718050> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230073 Archived-At: >> - if (fix_current_buffer) >> - { >> - if (! FRAME_LIVE_P (XFRAME (selected_frame))) >> - Fkill_emacs (Qnil); >> - if (XBUFFER (XWINDOW (selected_window)->contents) >> - != current_buffer) >> - Fset_buffer (XWINDOW (selected_window)->contents); >> - } > This part restores the current buffer from the selected-window's > buffer. With it deleted, what if a process filter or a timer switches > buffers while we are processing a key sequence? Indeed, what if? This is read_key_sequence: its return value should depend on where the keys&buttons are pressed rather than the context in which the function is called, so it should presumably not be affected by current-buffer as long as it uses the right set of active keymaps. I suspect we do need some `Fset_buffer (XWINDOW (selected_window)->contents)` maybe inside active_maps or right after `replay_sequence:` but I haven't managed to trigger problems linked to that yet. The `starting_buffer` business also looks a bit fishy. Stefan