unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: BUFFER_SWITCH_EVENT
Date: Tue, 25 Sep 2018 17:50:21 -0400	[thread overview]
Message-ID: <jwv7ej9469g.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pnx18kjc.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Sep 2018 22:05:43 +0300")

>> -	      if (fix_current_buffer)
>> -		{
>> -		  if (! FRAME_LIVE_P (XFRAME (selected_frame)))
>> -		    Fkill_emacs (Qnil);
>> -		  if (XBUFFER (XWINDOW (selected_window)->contents)
>> -		      != current_buffer)
>> -		    Fset_buffer (XWINDOW (selected_window)->contents);
>> -		}
> This part restores the current buffer from the selected-window's
> buffer.  With it deleted, what if a process filter or a timer switches
> buffers while we are processing a key sequence?

Indeed, what if?

This is read_key_sequence: its return value should depend on where the
keys&buttons are pressed rather than the context in which the function
is called, so it should presumably not be affected by current-buffer as
long as it uses the right set of active keymaps.

I suspect we do need some `Fset_buffer (XWINDOW
(selected_window)->contents)` maybe inside active_maps or right after
`replay_sequence:`  but I haven't managed to trigger problems linked to
that yet.

The `starting_buffer` business also looks a bit fishy.


        Stefan



  reply	other threads:[~2018-09-25 21:50 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 15:24 while-no-input interrupted by *shell* Michael Heerdegen
2018-09-24 16:14 ` Eli Zaretskii
2018-09-24 16:40   ` Stefan Monnier
2018-09-24 17:00     ` Eli Zaretskii
2018-09-24 18:35       ` Stefan Monnier
2018-09-24 18:48         ` Eli Zaretskii
2018-09-24 17:39   ` Michael Heerdegen
2018-09-24 18:00     ` Eli Zaretskii
2018-09-24 19:09       ` Michael Heerdegen
2018-09-24 19:06     ` Stefan Monnier
2018-09-25 13:09     ` Eli Zaretskii
2018-09-25 13:39       ` Michael Heerdegen
2018-09-25 14:14         ` Eli Zaretskii
2018-09-29  7:13           ` Eli Zaretskii
2018-09-25 15:25       ` BUFFER_SWITCH_EVENT (was: while-no-input interrupted by *shell*) Stefan Monnier
2018-09-25 16:01         ` Eli Zaretskii
2018-09-25 16:14           ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 16:28             ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 17:19               ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 17:28                 ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 18:14                   ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 18:32                     ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 19:05                     ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 21:50                       ` Stefan Monnier [this message]
2018-09-26  5:42                         ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-26 12:27                           ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-24 21:23   ` while-no-input interrupted by *shell* Andreas Schwab
2018-09-25 10:36     ` Michael Heerdegen
2018-09-24 16:19 ` Stefan Monnier
2018-09-25 17:47 ` while-no-input and pending input (was: while-no-input interrupted by *shell*) Michael Heerdegen
2018-09-25 17:53   ` Drew Adams
2018-09-26 12:50     ` while-no-input and pending input Michael Heerdegen
2018-09-26 14:18   ` while-no-input and pending input (was: while-no-input interrupted by *shell*) Eli Zaretskii
2018-09-26 17:57     ` while-no-input and pending input Michael Heerdegen
2018-09-26 19:06       ` Eli Zaretskii
2018-10-12 15:38         ` Michael Heerdegen
2018-10-12 15:44           ` Stefan Monnier
2019-02-17 23:44         ` Michael Heerdegen
2019-02-18 17:08           ` Eli Zaretskii
2019-02-18 19:08             ` Óscar Fuentes
2019-02-18 19:23               ` Eli Zaretskii
2019-02-18 22:32             ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7ej9469g.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).