From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fwd: Flymake and the 'face' property Date: Wed, 30 Jan 2019 04:37:32 -0500 Message-ID: References: <20190128152540.6870.46132@vcs0.savannah.gnu.org> <20190128152541.12A4D20B50@vcs0.savannah.gnu.org> <30bm401x64.fsf@fencepost.gnu.org> <83r2cw35jq.fsf@gnu.org> <83munk33gj.fsf@gnu.org> <83h8dr2yll.fsf@gnu.org> <83bm3z2vyv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176790"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 30 10:37:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gomJi-000jrd-30 for ged-emacs-devel@m.gmane.org; Wed, 30 Jan 2019 10:37:58 +0100 Original-Received: from localhost ([127.0.0.1]:34854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gomJh-0000XZ-31 for ged-emacs-devel@m.gmane.org; Wed, 30 Jan 2019 04:37:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gomJa-0000XM-Se for emacs-devel@gnu.org; Wed, 30 Jan 2019 04:37:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gomJZ-000233-Ri for emacs-devel@gnu.org; Wed, 30 Jan 2019 04:37:50 -0500 Original-Received: from [195.159.176.226] (port=52812 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gomJX-0001x8-Ss for emacs-devel@gnu.org; Wed, 30 Jan 2019 04:37:48 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1gomJO-000jTT-F1 for emacs-devel@gnu.org; Wed, 30 Jan 2019 10:37:38 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:JA8f+idKdOdAdCV2CWU2p8m5T2o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232821 Archived-At: > A 'face' property is documented for general use only for text, not for > symbol plists. But the `category` text-property uses as text-properties the properties of a symbol, so there is a real conflict in our current design. I think it might be worth taking a look at how hard/easy it would be to change the place where we store the face-id. IOW I wonder how much code out there depends on it. I have a vague recollection that many years ago there might have been code that used (get 'face) in order to test if `foo` is a face (because `facep` wasn't available yet, or only in XEmacs or something like that), but I don't know if my memory is right, nor do I know how much of that code might have survived until now. Outside of this I can't remember ever seeing 3rd-party Elisp code that depends on those internal details of our face system. Also, even if there is code out there that looks at this `face` property, maybe we change the property without breaking those packages (e.g. by storing the face-id in both properties, but only looking them up in the new property). Stefan