From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: fix for bug#34330 breaks makefile target complete in `compile' prompt Date: Sun, 15 Sep 2019 17:05:52 -0400 Message-ID: References: <8636gxq5wr.fsf@stephe-leake.org> <86tv9dnx1a.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65627"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 15 23:06:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9bii-000GwJ-NY for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 23:06:08 +0200 Original-Received: from localhost ([::1]:57172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9big-00075k-V0 for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 17:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49404) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9biX-00075J-8k for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:05:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9biV-0003c7-OB for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:05:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30593) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i9biV-0003bq-KJ for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:05:55 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7AE911008C2; Sun, 15 Sep 2019 17:05:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 314611005BA; Sun, 15 Sep 2019 17:05:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1568581553; bh=td42V/9BeNdKScMwFajGp165VybGGcQ4eTZJk6y1fX0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cJ0r2gFB4PWW0ZuWrjxk8AuzJhG70h+VXbhwug+Z2QVC1jVZfLoTPb4Kq+NopOnyI b1djj02oT+HiAMEQ5aaheT0V72QeC//9YpzXujvGSj7lRrY1e2cBAJADyWNr3Mbtfy Rjdhoh3Gz79JSjN7T2pbiz+3my9XFqdWLCxIC7VqjwuW1LinVIBHAlu7q9KR7GJd5v z/sFgXDW4cvYTfM0f4k+1kFmiy9uKcV3EumOKrvOa3qAQm2jXDc0PITKKlOSNUvwzI 74AjTEnMMr4QDQ8E7JPhynlt3BlTiTDQhPhf9zdwmtavMCKT9TICq8NPksOWmcBa00 8uvznUFymrSYg== Original-Received: from alfajor (104-222-123-223.cpe.teksavvy.com [104.222.123.223]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF941120B4D; Sun, 15 Sep 2019 17:05:52 -0400 (EDT) In-Reply-To: <86tv9dnx1a.fsf@stephe-leake.org> (Stephen Leake's message of "Sun, 15 Sep 2019 13:07:29 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240056 Archived-At: >> No. The idea rather is to decide on the completion-table to use only >> based on *where* we are. You can't easily know whether there are >> any completions (because it depends on completion-styles). > Hmm. Why don't we know the style? Won't completion-try-completion, using > the candidate completion table, return the right result? You could try and do that, but it might make things too slow (completion-at-point-functions is also called at times with no intention to actually perform the completion, but rather just to know if we're still in the same completion-spot as before, e.g. to know when to pop-down the *Completions* buffer). > comint-complete (although I think that means adding pcomplete/ls etc, so > it knows it's looking for a file). I don't think pcomplete/ls would help in any way. The issue is with *all* commands: we want to complete file-names by default (i.e. the absence of any other information). Also I think it makes sense to allow file-name completion for make arguments, since even if not listed explicitly in the Makefile, it's likely that "make " can be a valid&useful command. > Setting pcomplete-default-completion-function to 'ignore might work (ie, > "don't guess if you are not sure"). That could be done in > pcomplete-completions-at-point, so it doesn't affect the normal > operation of pcomplete. Oh, wait. When you said `pcomplete` before were you sometimes talking about the specific `pcomplete` command rather than about the pcomplete.el functionality in general? Nowadays the `pcomplete` command should basically not be used any more (the pcomplete functionality should be used from completion-at-point via pcomplete-completions-at-point instead). Stefan