From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] extend map-into Date: Tue, 08 Oct 2019 13:29:32 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42535"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrea Corallo , Nicolas Petton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 08 19:41:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHtUV-000AvC-2F for ged-emacs-devel@m.gmane.org; Tue, 08 Oct 2019 19:41:43 +0200 Original-Received: from localhost ([::1]:59338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHtUT-0001iW-0h for ged-emacs-devel@m.gmane.org; Tue, 08 Oct 2019 13:41:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50635) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHtIo-0001oB-GZ for emacs-devel@gnu.org; Tue, 08 Oct 2019 13:29:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHtIn-0000Wk-6O for emacs-devel@gnu.org; Tue, 08 Oct 2019 13:29:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45302) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHtIn-0000W5-2L for emacs-devel@gnu.org; Tue, 08 Oct 2019 13:29:37 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A93B4100F15; Tue, 8 Oct 2019 13:29:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4EE22100E9E; Tue, 8 Oct 2019 13:29:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1570555774; bh=mW6u828nx80x5rjKiQFA08Sf8vEkw9WmP/ADF20+SfY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OqgLI04ZzcvR+nRBkPTkefcD9yEB0g+bJI9V8gJWXDCk2o6q2N1I+iBqYL8G+zxR1 YlbAH+Rd8apkXoiooJgKxRqbQ1VnzTUVuZAitAYrMyhNwvD/cC2EvMTJ0wvt0+h5LK D5wmr+NEGV5dbrdshvq0PNRa3yUIUkk1DOAXRoyuzHqBFbD9OX/smC+j3hiecxj9by u8NtWQw6o6D9DwU4eU2fB5IWei+H5LIXTPyp4slkGtnbgP26TUOzvcJ/rHeJaAwU5q irRB4pSOpA7O4cnNQip+9Fjx7ZMLUMpTkM/1E/uBB036n+t++4nkXUsFMT26pMZ+Gt 0VrARHjpOhUpw== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 18C9712093F; Tue, 8 Oct 2019 13:29:34 -0400 (EDT) In-Reply-To: (Andrea Corallo's message of "Sun, 06 Oct 2019 20:59:50 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240756 Archived-At: >> I guess we could use a `type` that's not a symbol but a list (whose >> head is a symbol and the rest are the args), but it could be a bit >> inconvenient (and would impact efficiency as well because it makes the >> cl-generic dispatch more complex). > Cool, is the attached patch doing what you suggest? Yes. Have you taken a look at the performance impact? E.g. how much slower does something like (map-into nil 'alist) becomes (this should be pretty the worst case which spends most/all its time in the dispatch)? Nicolas, WDYT? Stefan