From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Pip Cet <pipcet@gmail.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
emacs-diffs@gnu.org, emacs-devel@gnu.org
Subject: Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc.
Date: Tue, 07 Jan 2020 15:06:09 -0500 [thread overview]
Message-ID: <jwv7e23yqvg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAOqdjBe=_vu+mrqsCyJHnz86c1QMJZTyJ+==vx7Ci-RGXLmHYw@mail.gmail.com> (Pip Cet's message of "Tue, 7 Jan 2020 19:36:23 +0000")
> Again, I don't think there's any reason for using markers as keys in
> an equal-based hash table. But if you do, what you probably meant was
> to use an eq-based hash table, and that used to work; now it doesn't.
>
> (puthash marker value ht)
> <...move marker...>
> (gethash marker ht)
If it hurts don't do that: the same happens with
(puthash conscell value ht)
<...setcar conscell...>
(gethash conscell ht)
-- Stefan
next prev parent reply other threads:[~2020-01-07 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200107192947.22465.82501@vcs0.savannah.gnu.org>
[not found] ` <20200107192950.02DA2211A5@vcs0.savannah.gnu.org>
2020-01-07 19:36 ` master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc Pip Cet
2020-01-07 20:06 ` Stefan Monnier [this message]
2020-01-07 23:37 ` Stefan Monnier
2020-01-08 19:23 ` Pip Cet
2020-01-07 20:19 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7e23yqvg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).