From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: whitespace-only changes Date: Fri, 21 Aug 2020 09:13:41 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6258"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: eliz@gnu.org, emacs-devel@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 21 15:14:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k96sG-0001VV-D4 for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 15:14:28 +0200 Original-Received: from localhost ([::1]:57910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k96sF-0003ff-FQ for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Aug 2020 09:14:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k96rd-0002cB-Ib for emacs-devel@gnu.org; Fri, 21 Aug 2020 09:13:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k96rb-0006KD-Bj; Fri, 21 Aug 2020 09:13:48 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DC9CE80541; Fri, 21 Aug 2020 09:13:43 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5A34880DC9; Fri, 21 Aug 2020 09:13:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598015622; bh=hJBQp1YZCN1K6/eZS4GiWIEkc+dWRGk/YF8hPM7Rd9U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OVY5kbBzktIOgGrPdUbblJieYWMn5QYZHYKxuFukxgjFW5cSALW25gFZKTf8thxO4 wnj1KOM34m+dO+whWIiYqG2Nl8Yh9ibhWNnMxDWYrGGL5zFATpuIjll/G7d6w68RK1 BksaCl2kKwdOA3UCqPCPxl2FU5QCWGxq9BCd880XJvbQ2vbUgW1TO2kHF2syeCpZ/5 /KbevnpoG6bq0Wv41RtoiPBeCum3IIjk73viUQvRxxvFe4evkfJJub5AnLDsYQKK4K YA8v5scA9hbZNpcpoGbkwZhRQiLd5OShIutIUZGKBby2HTdwaC5xWpdIbDIdZwvL+U s/QgFjD2rDPfA== Original-Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 226E912038D; Fri, 21 Aug 2020 09:13:42 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Wed, 19 Aug 2020 23:06:55 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/21 09:13:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254075 Archived-At: > I am sure he knows what he's talking about, but it is unfortunate that > we cannot fix bad indentation. Can't we correct this problem somehow? FWIW, I think it's OK to commit whitespace-only changes when they fix a "serious" problem, e.g. when the indentation is confusing. AFAIK in the sample suggested commit, none of the changes were "serious" (there was even one reindentation where I happen to prefer the current indentation (even though it doesn't match what our auto-indent code does)). > For instance, label whitespace changes clearly in the commit log, and > change some tools to ignore them? I don't think whitespace-only changes are justified often enough to warrant all that work (there are many tools that would be affected). More useful would be to make the tools aware of file where whitespace changes are (mostly) not significant so they can auto-resolve some conflicts. Stefan