From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Richard Stallman <rms@gnu.org>
Cc: eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: whitespace-only changes
Date: Fri, 21 Aug 2020 09:13:41 -0400 [thread overview]
Message-ID: <jwv7dtsw3kt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1k8aul-0001mr-Mg@fencepost.gnu.org> (Richard Stallman's message of "Wed, 19 Aug 2020 23:06:55 -0400")
> I am sure he knows what he's talking about, but it is unfortunate that
> we cannot fix bad indentation. Can't we correct this problem somehow?
FWIW, I think it's OK to commit whitespace-only changes when they fix
a "serious" problem, e.g. when the indentation is confusing.
AFAIK in the sample suggested commit, none of the changes were "serious"
(there was even one reindentation where I happen to prefer the current
indentation (even though it doesn't match what our auto-indent code
does)).
> For instance, label whitespace changes clearly in the commit log, and
> change some tools to ignore them?
I don't think whitespace-only changes are justified often enough to
warrant all that work (there are many tools that would be affected).
More useful would be to make the tools aware of file where whitespace
changes are (mostly) not significant so they can auto-resolve
some conflicts.
Stefan
next prev parent reply other threads:[~2020-08-21 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 3:06 whitespace-only changes Richard Stallman
2020-08-20 8:04 ` Mattias Engdegård
2020-08-20 13:19 ` Eli Zaretskii
2020-08-20 13:32 ` Lars Ingebrigtsen
2020-08-20 14:54 ` David Engster
2020-08-21 3:33 ` Richard Stallman
2020-08-21 8:55 ` Sergey Organov
2020-08-23 4:42 ` Richard Stallman
2020-08-20 20:50 ` Daniel Martín
2020-08-20 20:54 ` Lars Ingebrigtsen
2020-08-20 21:07 ` Daniel Martín
2020-08-21 13:13 ` Stefan Monnier [this message]
2020-08-22 3:51 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7dtsw3kt.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).