From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master d067ac5: Remove more compat code from prolog.el Date: Fri, 25 Sep 2020 08:39:23 -0400 Message-ID: References: <20200925093755.19433.41297@vcs0.savannah.gnu.org> <20200925093756.C7849209D4@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 25 14:40:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLn1o-0005L4-UZ for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 14:40:44 +0200 Original-Received: from localhost ([::1]:35442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLn1n-0004Qe-VG for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Sep 2020 08:40:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLn0d-0002sx-MF for emacs-devel@gnu.org; Fri, 25 Sep 2020 08:39:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLn0a-0007yJ-IY for emacs-devel@gnu.org; Fri, 25 Sep 2020 08:39:30 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DFE51813A2; Fri, 25 Sep 2020 08:39:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A8D3180921; Fri, 25 Sep 2020 08:39:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1601037564; bh=OxI37d53EQG0GMksm3toNHJ5i4HNeod854WfGcP0+tc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SdEqzxqwQ4onXJN4P9ojgF8hzVV2tDfJeDoxk9Cj3wOvJibfGAPH1pojgIetnm/zM keddwCayj89da0weefRNYFNIwGQ3OYgaN0DRpzy37QaXuKEXGnfmVJA8GJP+gyk6os ArAjdLtVA3iBmht7V7G8qN8o2fje7kFO4RP/AWLKUTECHg6WgQ6oSsNR8GHtLznUaQ qqzS3ah3TbzK7Jv8qakkDCZdcmbKwTmN+N5W4rltjoZXVvnlHMJMYNGujl/V8sM8et foKmu6YCjKpQ9YObu2csrbsMNlOCZxmDrKCGKKeFT7uMI5MvsFAj84yVTrzBvvo9qZ UxOGMPkNBw2wA== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7688E1203D6; Fri, 25 Sep 2020 08:39:24 -0400 (EDT) In-Reply-To: <20200925093756.C7849209D4@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 25 Sep 2020 05:37:56 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/25 08:39:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256417 Archived-At: > @@ -1999,7 +1997,7 @@ Argument BOUND is a buffer position limiting searching." > (if (eq prolog-system 'mercury) > (list > (regexp-opt prolog-directives-i 'words) > - 0 'prolog-warning-face))) > + 0 prolog-warning-face))) > ;; Inferior mode specific patterns > (prompt > ;; FIXME: Should be handled by comint already. I think this one is wrong: the font-lock data-structure built here should contain at this position an *expression* that returns a face when passed to `eval`. IOW with the above change the value held by `prolog-warning-face` needs to be "an expression that evaluates to a face" rather than "a face name". This will still work as long as `prolog-warning-face` has value `font-lock-warning-face` since it's both the name of a face and the name of an expression whose value is that same face (because it's also the name of a variable whose value is, by default, itself). Stefan