From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/bytecode-speedup 1dca615cf9 08/11: Move a runtime interpreter check to ENABLE_CHECKING Date: Tue, 11 Jan 2022 12:22:49 -0500 Message-ID: References: <164191984181.15147.4731922332585678354@vcs2.savannah.gnu.org> <20220111165050.357D6C0DA35@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 18:37:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7L5C-0002UG-LN for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 18:37:18 +0100 Original-Received: from localhost ([::1]:56526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7L57-0006Cu-CU for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 12:37:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KrQ-0003Mc-66 for emacs-devel@gnu.org; Tue, 11 Jan 2022 12:23:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7KrL-0000lk-Ol for emacs-devel@gnu.org; Tue, 11 Jan 2022 12:23:02 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DCD4F4422C2; Tue, 11 Jan 2022 12:22:52 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 145484422C7; Tue, 11 Jan 2022 12:22:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641921771; bh=L2vp5P8i0PsHJGP9pPKmrKNB8jmY4pudFXiWTmlQX9s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bq/Vp0O+jOvtv0p3y5zFgf9+8nsetlTpRsf/yvYf7wy2soFHadaC6dTJQotfFqF9G SWSAfm0U0P2zC0v8wufvgvl8A4WaUhjjR3gtg3lg2QkJKJZ2RaxjLzBByfNT0o5prG 0wQ4u7shKDO1C7J+mKGQuqNSQGGwWswUg/GcCvWksGtNO40/CchFPTsZFVhCd+LymQ 0H1fdPqXA06cVLtIJe0gVcKk5VClAtTopW4PTHH9WyVQwopnR48uaV7ckc6i4pToXo UAzHj9urxdlydQ33/x+zJ/o4U8dKzhwGhHQNJUgK0RSq5idZN9u3POkW5mVfhbhqvI RT5lB9sLxc1oA== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E2C081202DB; Tue, 11 Jan 2022 12:22:50 -0500 (EST) In-Reply-To: <20220111165050.357D6C0DA35@vcs2.savannah.gnu.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Tue, 11 Jan 2022 11:50:50 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284621 Archived-At: > + /* The byte code should have been properly pinned. */ > eassert (SDATA (bytestr) == bytestr_data); > - > /* Binds and unbinds are supposed to be compiled balanced. */ > - if (SPECPDL_INDEX () != count) > - { > - if (SPECPDL_INDEX () > count) > - unbind_to (count, Qnil); > - error ("binding stack not balanced (serious byte compiler bug)"); > - } > + eassert (SPECPDL_INDEX () == count); This makes compiler debugging harder since it crashes Emacs instead of signaling a clean error :-( Maybe this actually should not be an error at all, and instead `bytecomp.el` could skip emitting trailing `unbind`s and rely on `exec_byte_code` doing the unbinds instead. I think this would result in a speed up (and a more compact bytecode) with dynbind code. Not sure how it'd work out with lexbind code where it's much more common for functions not to need any `unbind`. Stefan