From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Patch/Question] Likely bugs in mailcap docs and mailcap-view-file Date: Fri, 14 Jan 2022 17:32:32 -0500 Message-ID: References: <875yqmvvx1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26895"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 23:33:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8V8b-0006o0-OQ for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 23:33:37 +0100 Original-Received: from localhost ([::1]:59332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8V8a-0005wF-OO for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 17:33:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8V7i-0004vv-9m for emacs-devel@gnu.org; Fri, 14 Jan 2022 17:32:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8V7e-0004Gu-Ft; Fri, 14 Jan 2022 17:32:41 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 480DF10008C; Fri, 14 Jan 2022 17:32:35 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BB2F3100121; Fri, 14 Jan 2022 17:32:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642199553; bh=/83zxSHDje8tAD+dztNr4iLpcFOcnuK1weF9yKjL6io=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kVOMrrk/zdiNlaWIuj2LmGzNdQctEE+v+iLECX/NJO1N0zL0qzRW8+jCuSGTDIwLq vVcTYmklbseEkd/X+i9uG6fJn3mOm2h5yV3PS3LkVL5POWDQ2LKjUo9d/UkEOtzNSl 6+3mLeZhF+1A8yooRWiHdtnO2YAEocnfaz/Mg/ZHf6kZhV3NzXR+IhO+g3XuQIIrGq H6h1354uBBpXm76wrfp5vskQWFWBXK7dzBwrQXxFQCIdgeYhLnfUC02ElUFenR6NyZ 6nlRtRTYQ0Tc2vDURoAfINeODV++ArVkksHeOjmnkURvmMj/70B+bggXG0j42nnCUK GzzftZgXINVsg== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 89363120746; Fri, 14 Jan 2022 17:32:33 -0500 (EST) In-Reply-To: <875yqmvvx1.fsf@gnu.org> (Tassilo Horn's message of "Fri, 14 Jan 2022 22:24:43 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284761 Archived-At: > So I propose the attached patch which teaches `mailcap-view-file' the > symbol/function-valued viewer case and adjust the docs to match what's > already there. [...] > Does anyone see a problem with that? I'm not very familiar with that > code. I'm not familiar either, but it looks OK. Any chance you could be convinced to throw in some regression test? Stefan