From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/emms e9fa4c095d: * emms.el: reverse the order players are collected Date: Tue, 06 Sep 2022 21:50:40 -0400 Message-ID: References: <166250171605.12534.6807904164286037648@vcs2.savannah.gnu.org> <20220906220156.5255DC0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Yoni Rabkin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 03:51:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVkE5-0000Uy-Hi for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 03:51:37 +0200 Original-Received: from localhost ([::1]:48706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVkE3-0005jS-Ou for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Sep 2022 21:51:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVkDJ-00053N-8Z for emacs-devel@gnu.org; Tue, 06 Sep 2022 21:50:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVkDG-00017f-6q for emacs-devel@gnu.org; Tue, 06 Sep 2022 21:50:48 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7DE95100117; Tue, 6 Sep 2022 21:50:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4486B10001F; Tue, 6 Sep 2022 21:50:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662515441; bh=3XUTf+rhEjVcAgI8JWE+VRNqopQx54JzjTpl5UzDOVM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=elH6eqtdZar6YsNWtCESqtPr68YQsvkiv154NeTSzJqKlAIe1SyY1fY5CWlfn0OeY 0XpwlqiGuxxK4Y/2alKhRXUWvt52TnmXqOLagcp41JYKNuWk7R65RmK379IFOJwO57 VG8jSFjnKk+rn/NoP35qw+f1cWWKSiiuaOXrPsaJKLsrqIJeI9+TTHTPmTfyUb17b9 3v60I/YouvWA9ftrEb/d2c+Jqe7m/pjlXpTOUH1pn+p+4mrA46+O8/+rDSgXICoNKl QD4EmL1ceZfZleawoYkdPFYq9PhJumoUL4HWpLZSqsRP6XcXtfgLyY/P4+eaJCf+D3 Tolw7X2jbNhgw== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 08AD01204E9; Tue, 6 Sep 2022 21:50:41 -0400 (EDT) In-Reply-To: <20220906220156.5255DC0088A@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 6 Sep 2022 18:01:56 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294806 Archived-At: > --- a/emms.el > +++ b/emms.el > @@ -1511,7 +1511,7 @@ If the track can be played by more than one player,= call > (mapc > #'(lambda (player) > (when (funcall (emms-player-get player 'playablep) track) > - (push player players))) > + (setq players (append players `(,player))))) > emms-player-list) > (if (< 1 (length players)) > (emms-players-preference track players) This changes the code's complexity from O(N) to O(N=B2) in the number of players. Maybe it's not a very big deal, but the standard way to avoid this is to use `push` inside the loop followed by `nreverse` at the of the loop. Stefan