unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 570a11052b: keymap.el: Ease up support for non-`kbd` formats.
Date: Sun, 02 Oct 2022 15:51:19 -0400	[thread overview]
Message-ID: <jwv7d1if1j1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k05i9ivs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 02 Oct 2022 20:32:07 +0200")

> (Re-sent to the right emacs-devel address...)

[ Same here ;-)  ]

> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>>     While we want to standardize on the `kbd` syntax for user-facing code,
>>     the internal vector representation of key sequences is not going away,
>>     so let's not impose silly `key-description + key-parse` roundtrips.
>
> I don't think this is a good idea.  Before this change, `keymap-set'
> (and friends) provided real value in giving the users feedback on the
> consistent format we've chosen to document support.  With this, you
> reintroduce the confusion we have with the myriad different (and
> incomplete) syntaxes, and the next question will inevitably be why
> `keymap-set' doesn't support the rest.

I thought I explained in the commit message: the low-level vector
representation is not going away any time soon (there's not even a plan
for how this could happen, or anyone who mentioned a desire to make it
happen).

So it makes no sense to force people through (key-parse (key-description
<vector>)) when they have a low-level vector keysequence to start with.


        Stefan




  reply	other threads:[~2022-10-02 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166473415340.3541.7915775151764125824@vcs2.savannah.gnu.org>
     [not found] ` <20221002180913.AD50AC0004A@vcs2.savannah.gnu.org>
2022-10-02 18:32   ` master 570a11052b: keymap.el: Ease up support for non-`kbd` formats Lars Ingebrigtsen
2022-10-02 19:51     ` Stefan Monnier [this message]
     [not found]   ` <87lepy9jly.fsf@gnus.org>
     [not found]     ` <jwvczbaf1ol.fsf-monnier+Inbox@gnu.org>
2022-10-02 19:53       ` Lars Ingebrigtsen
2022-10-02 20:49         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7d1if1j1.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).