From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 12:21:24 -0500 Message-ID: References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8079"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , Jeremy Bryant , "emacs-devel@gnu.org" To: Jay Kamat Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:22:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf1AF-0001oY-DC for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:22:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf19E-0006L5-UJ; Tue, 27 Feb 2024 12:21:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf192-0006FQ-A8 for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:21:35 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf18z-00011n-EY for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:21:31 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0D45D80974; Tue, 27 Feb 2024 12:21:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1709054485; bh=hVkhF1kZxhZ98cNavBfJST7hTwkqPkYWS1HkvnBGXR4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ny8ZL94qai4MKPJXOcpdPb/ZodFEqA6ww5u4QyUs/VK2Lia/Vz+nR1uuVrhHankHC P9aW6LlFWUEPA8AUSO3ZsjWCQ0YbKE0PBzWIEWQEHUcgaZhXAi/MXKhnXrm5jTwjdU 32JiYSYNsfIllqzanGSOgqt4q73kKzM3uoQ18H5qrsimGhjBPRfn4qELpSUqUFb4i3 vGGDueJBtl6GxwEqti99RYg86TUdWZOYrHoKqUMkqPbSTxpkJv/UpkJnMEDq2BRPUQ w/F7PGM6KQrFWTbuMnWHxuyaWwXXDkwR9xyfMx8Ct69lQP5mTBzot7PCXXHQWE+BKu BUYLG1QvsJexA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D6C2380240; Tue, 27 Feb 2024 12:21:25 -0500 (EST) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B2524120832; Tue, 27 Feb 2024 12:21:25 -0500 (EST) In-Reply-To: <87msrleuwd.fsf@eve> (Jay Kamat's message of "Tue, 27 Feb 2024 08:13:57 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316595 Archived-At: >> -(defun rmsbolt--convert-file-name-to-system-type (file-name) >> +(defun rmsbolt--convert-file-name-to-system-type (file-name) ;perhaps use >> `convert-standard-filename'? > > Right now, a contributor is trying to improve this area/enable tramp > support - so I'd like to keep this as stable as possible while they do > so. But this is a great suggestion - I'll let them know about this function > and hopefully it will help them in their change as well! I haven't looked at the code but I'll point out that `convert-standard-filename` is meant to *define* the name of a "standard" file, so its argument is usually very static. It doesn't make sense to apply it to something like `buffer-file-name` which is already supposed to be a valid filename. Also, I see: (rmsbolt--convert-file-name-to-system-type (shell-quote-argument which is very weird. The reverse would make more sense. Also I think `shell-quote-argument` should be applied to most parts of `rmsbolt--demangle-command`. This function is also odd in that it calls `rmsbolt--convert-file-name-to-system-type` on the files of the demangler but not those of the `mv`. Stefan