unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: some subdirs.el won't be loaded
Date: Tue, 24 May 2005 10:51:51 -0400	[thread overview]
Message-ID: <jwv64x8adhb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1DaZEt-0004h0-00@etlken> (Kenichi Handa's message of "Tue, 24 May 2005 22:14:31 +0900")

> I found that some subdirs.el won't be loaded.  It seems that
> the reason is this change.

> 2004-08-20  Stefan Monnier  <monnier@iro.umontreal.ca>

> 	* startup.el (normal-top-level-add-subdirs-to-load-path):
> 	Avoid unnecessarily checking system-type.
> 	(normal-top-level): Set TERM to "dumb".  Simplify.
>                                                  ^^^^^^^^

> normal-top-level-add-to-load-path appends directories to
> load-path destructively, but because of above change,
> subdirs.el in those newly added directories are not loaded.

Aaaahhh indeed.
Would the patch below fix things?


        Stefan


--- startup.el	19 mai 2005 11:05:48 -0400	1.357
+++ startup.el	24 mai 2005 10:51:21 -0400	
@@ -368,11 +368,17 @@
     ;; of that dir into load-path,
     ;; Look for a leim-list.el file too.  Loading it will register
     ;; available input methods.
-    (dolist (dir load-path)
+    (let ((tail load-path) dir)
+      (while tail
+        (setq dir (car tail))
       (let ((default-directory dir))
 	(load (expand-file-name "subdirs.el") t t t))
       (let ((default-directory dir))
-	(load (expand-file-name "leim-list.el") t t t)))
+          (load (expand-file-name "leim-list.el") t t t))
+        ;; We don't use a dolist loop and we put this "setq-cdr" command at
+        ;; the end, because the subdirs.el files may add elements to the end
+        ;; of load-path and we want to take it into account.
+        (setq tail (cdr tail))))
     (unless (eq system-type 'vax-vms)
       ;; If the PWD environment variable isn't accurate, delete it.
       (let ((pwd (getenv "PWD")))

  reply	other threads:[~2005-05-24 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-24 13:14 some subdirs.el won't be loaded Kenichi Handa
2005-05-24 14:51 ` Stefan Monnier [this message]
2005-05-25  0:49   ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv64x8adhb.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).