From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: asm-mode patch to allow per-file comment character setting from file locals Date: Sun, 11 Jun 2006 17:20:17 -0400 Message-ID: References: <2E2BAEFF-FEAD-4616-87CD-3B77D2734256@alastairs-place.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1150060861 2456 80.91.229.2 (11 Jun 2006 21:21:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Jun 2006 21:21:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 11 23:20:58 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FpXMX-00088T-9w for ged-emacs-devel@m.gmane.org; Sun, 11 Jun 2006 23:20:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FpXMW-0004fl-IH for ged-emacs-devel@m.gmane.org; Sun, 11 Jun 2006 17:20:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FpXMM-0004fL-Ho for emacs-devel@gnu.org; Sun, 11 Jun 2006 17:20:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FpXMK-0004et-RB for emacs-devel@gnu.org; Sun, 11 Jun 2006 17:20:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FpXMK-0004eq-P8 for emacs-devel@gnu.org; Sun, 11 Jun 2006 17:20:36 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FpXUu-0004Ig-80 for emacs-devel@gnu.org; Sun, 11 Jun 2006 17:29:28 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id DBA122CF5ED; Sun, 11 Jun 2006 17:20:32 -0400 (EDT) Original-Received: from dino15.iro.umontreal.ca (dino15.iro.umontreal.ca [132.204.26.95]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 8EE9E445C; Sun, 11 Jun 2006 17:20:17 -0400 (EDT) Original-Received: by dino15.iro.umontreal.ca (Postfix, from userid 20848) id 779696AA4E; Sun, 11 Jun 2006 17:20:17 -0400 (EDT) Original-To: Alastair Houghton In-Reply-To: <2E2BAEFF-FEAD-4616-87CD-3B77D2734256@alastairs-place.net> (Alastair Houghton's message of "Fri, 9 Jun 2006 13:00:37 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55838 Archived-At: I don't have time to look in detail at the patch, but here are some comments: > +(make-variable-buffer-local 'asm-comment-char) Please don't do that. USe make-local-variable where necessary instead. > +(put 'asm-comment-char 'safe-local-variable t) Use an actual function instead rather than just t. Stefan