From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: asm-mode patch to allow per-file comment character setting from file locals
Date: Sun, 11 Jun 2006 17:20:17 -0400 [thread overview]
Message-ID: <jwv64j7s869.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <2E2BAEFF-FEAD-4616-87CD-3B77D2734256@alastairs-place.net> (Alastair Houghton's message of "Fri, 9 Jun 2006 13:00:37 +0100")
I don't have time to look in detail at the patch, but here are some comments:
> +(make-variable-buffer-local 'asm-comment-char)
Please don't do that. USe make-local-variable where necessary instead.
> +(put 'asm-comment-char 'safe-local-variable t)
Use an actual function instead rather than just t.
Stefan
next prev parent reply other threads:[~2006-06-11 21:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 12:00 asm-mode patch to allow per-file comment character setting from file locals Alastair Houghton
2006-06-11 21:20 ` Stefan Monnier [this message]
2006-06-12 9:46 ` Alastair Houghton
2006-06-12 13:12 ` David Kastrup
2006-06-12 15:02 ` Alastair Houghton
2006-06-12 22:58 ` David Kastrup
2006-06-13 10:36 ` Alastair Houghton
2006-06-13 17:56 ` Eli Zaretskii
2006-06-13 19:27 ` [OT] Netiquette (was: Re: asm-mode patch to allow per-file comment character setting from file locals) Alastair Houghton
2006-06-13 22:21 ` Thien-Thi Nguyen
2006-06-14 11:25 ` Alastair Houghton
2006-06-14 3:30 ` Eli Zaretskii
2006-06-14 10:53 ` Alastair Houghton
2006-06-14 12:04 ` [OT] Netiquette David Kastrup
2006-06-14 15:31 ` Alastair Houghton
2006-06-14 15:43 ` Sam Steingold
2006-06-14 16:28 ` Alastair Houghton
2006-06-14 16:35 ` Sam Steingold
2006-06-14 18:09 ` Thien-Thi Nguyen
2006-06-14 16:17 ` Chong Yidong
2006-06-14 16:26 ` David Kastrup
2006-06-14 16:40 ` Alastair Houghton
2006-06-14 17:32 ` Sam Steingold
2006-06-15 8:30 ` Richard Stallman
2006-06-15 8:57 ` Alastair Houghton
2006-06-16 6:01 ` Richard Stallman
2006-06-16 18:48 ` asm-mode comment char patch (was: [OT] Netiquette) Alastair Houghton
2006-06-17 17:57 ` Richard Stallman
2006-06-15 1:58 ` [OT] Netiquette Miles Bader
2006-06-14 5:11 ` asm-mode patch to allow per-file comment character setting from file locals Miles Bader
2006-06-14 11:18 ` [OT] Whether those with gnu.org addresses in any way represent FSF (was: Re: asm-mode patch to allow per-file comment character setting from file locals) Alastair Houghton
2006-06-14 12:29 ` [OT] Whether those with gnu.org addresses in any way represent FSF Miles Bader
2006-06-14 12:33 ` Alastair Houghton
2006-06-14 12:58 ` nferrier
2006-06-12 22:58 ` asm-mode patch to allow per-file comment character setting from file locals Thien-Thi Nguyen
2006-06-13 12:19 ` Masatake YAMATO
2006-06-13 23:20 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv64j7s869.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).