From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Herbert Euler" <herberteuler@hotmail.com>
Cc: rudalics@gmx.at, acm@muc.de, emacs-devel@gnu.org, handa@m17n.org
Subject: Re: C++ mode and c-beginning-of-current-token
Date: Thu, 17 May 2007 10:32:38 -0400 [thread overview]
Message-ID: <jwv646rjzs7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BAY143-F267C591CC121BA0642BF90DA330@phx.gbl> (Herbert Euler's message of "Thu\, 17 May 2007 20\:52\:33 +0800")
> Can I ask a silly question, too? There are two "calling"s of
> UPDATE_SYNTAX_TABLE_BACKWARD in `skip_chars', one with the "argument"
> (pos), the other with (pos - 1). To me, the second one does not look
> like a typo, but a correct piece of code on purpose. Yes, changing it
> from (pos - 1) to (pos) works, but it seems to be dangerous to me.
The important part is to make sure that the syntax-table is up-to-date for
the char being read, when to char is passed to `SYNTAX'.
Also, it is important to update the syntax-table only after making sure that
the new position is valid. So I believe the patch below is what we want.
Stefan
--- orig/src/syntax.c
+++ mod/src/syntax.c
@@ -1691,10 +1691,10 @@
p = GPT_ADDR;
stop = endp;
}
+ UPDATE_SYNTAX_TABLE_BACKWARD (pos - 1);
if (! fastmap[(int) SYNTAX (p[-1])])
break;
p--, pos--;
- UPDATE_SYNTAX_TABLE_BACKWARD (pos - 1);
}
}
}
next prev parent reply other threads:[~2007-05-17 14:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 10:39 C++ mode and c-beginning-of-current-token Herbert Euler
2007-05-12 13:19 ` Alan Mackenzie
2007-05-12 14:30 ` Herbert Euler
2007-05-12 14:33 ` Herbert Euler
2007-05-12 16:02 ` Herbert Euler
2007-05-12 15:30 ` Herbert Euler
2007-05-12 18:49 ` Alan Mackenzie
2007-05-13 0:51 ` Herbert Euler
2007-05-13 10:01 ` Alan Mackenzie
2007-05-14 2:00 ` Herbert Euler
2007-05-14 8:50 ` Alan Mackenzie
2007-05-14 9:24 ` Herbert Euler
2007-05-14 16:58 ` Stefan Monnier
2007-05-15 3:45 ` Herbert Euler
2007-05-15 6:39 ` martin rudalics
2007-05-16 16:15 ` Stefan Monnier
2007-05-15 13:30 ` Herbert Euler
2007-05-16 8:01 ` Herbert Euler
2007-05-16 8:05 ` Herbert Euler
2007-05-17 2:12 ` Kenichi Handa
2007-05-17 10:18 ` martin rudalics
2007-05-17 12:52 ` Herbert Euler
2007-05-17 13:51 ` martin rudalics
2007-05-17 21:40 ` martin rudalics
2007-05-17 14:32 ` Stefan Monnier [this message]
2007-05-17 14:45 ` martin rudalics
2007-05-18 13:00 ` Richard Stallman
2007-05-18 23:39 ` Herbert Euler
2007-05-19 22:31 ` Richard Stallman
2007-05-19 12:59 ` martin rudalics
2007-05-19 15:18 ` Stefan Monnier
2007-05-19 17:48 ` martin rudalics
2007-05-21 13:01 ` Kenichi Handa
2007-05-21 14:00 ` Stefan Monnier
2007-05-22 1:37 ` Kenichi Handa
2007-05-22 10:26 ` Stefan Monnier
2007-05-22 12:08 ` Kenichi Handa
2007-05-20 6:50 ` Richard Stallman
2007-05-16 9:00 ` martin rudalics
2007-05-16 11:12 ` Herbert Euler
2007-05-16 12:21 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv646rjzs7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=herberteuler@hotmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).