unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: completion-all-completions-with-base-size
Date: Sat, 18 Oct 2008 21:59:37 -0400	[thread overview]
Message-ID: <jwv63np1h9u.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ubpxhlfq1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Oct 2008 00:07:34 +0200")

>> >> > so it sounds like the above NEWS entry does not warrant any
>> >> > documentation in the manuals?  Why then it was added to NEWS?
>> >> 
>> >> Because some functions may call all-completions in a context where
>> >> someone has set completion-all-completions-with-base-size
>> >> (e.g. when all-completions is used internally by a functional
>> >> completion table), in which case it may be surprised by the extra `cdr'
>> >> (which could cause `length' or `mapcar' to signal an error).
>> 
>> > Well, I'm probably missing something, because I couldn't see how what
>> > all-completions returns could depend on
>> > completion-all-completions-with-base-size.  Please help me
>> > understand that.
>> 
>> Again, it's only in the case where the completion table is a function,
>> and only if that function depends on
>> completion-all-completions-with-base-size.

> If these are the only situations, then I don't think
> completion-all-completions-with-base-size warrants to be documented in
> the ELisp manual.  Whoever uses functions from minibuffer.el for
> completion tables ought to know about this variable and its role.

As mentioned, I hope it'll actually disappear.  But in the mean time,
the effect of completion-all-completions-with-base-size can sometimes be
exposed to code which knows nothing about the new minibuffer.el code.


        Stefan





  reply	other threads:[~2008-10-19  1:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-18 13:03 completion-all-completions-with-base-size Eli Zaretskii
2008-10-18 19:31 ` completion-all-completions-with-base-size Stefan Monnier
2008-10-18 20:08   ` completion-all-completions-with-base-size Eli Zaretskii
2008-10-18 21:55     ` completion-all-completions-with-base-size Stefan Monnier
2008-10-18 22:07       ` completion-all-completions-with-base-size Eli Zaretskii
2008-10-19  1:59         ` Stefan Monnier [this message]
2008-10-19  7:14           ` completion-all-completions-with-base-size Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv63np1h9u.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).