unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Tobias C. Rittweiler" <tcr@freebits.de>
Cc: emacs-devel@gnu.org
Subject: Re: `font-lock-extend-region-functions' vs. `font-lock-extend-after-change-region-function'
Date: Wed, 29 Apr 2009 16:26:38 -0400	[thread overview]
Message-ID: <jwv63gn1a96.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ocufz7d5.fsf@freebits.de> (Tobias C. Rittweiler's message of "Wed, 29 Apr 2009 19:40:06 +0200")

>> > But the new region that EXTEND is called with begins at 523, and not 701
>> > even though we processed the region between 523 and 701 already.
>> > This seems more inefficient than it needs to be if I'm not missing
>> > anything.
>> You're not missing anything.  It's an inefficiency in jit-lock, indeed.
>> jit-lock asks font-lock to highlight 1-523 and font-lock has no way to
>> tell jit-lock that the first call already highlighted 1-701, so next
>> time jit-lock needs highlighting it will do 523-1034 because it doesn't
>> know that 523-701 was done already.
> Is this intended to be fixed? For example, the extending of the
> font-lock region could be made a seperate step which
> `jit-lock-fontify-now' has to run explicitly.

Yes.  This problem was introduced in Emacs-22 but at the time I decided
it was better to "keep it that way for now" (the freeze was coming) and
fix it for Emacs-23, but I never got around to do it.

The way I imagine fixing it is by changing jit-lock-functions such that
the functions on that hook (e.g. font-lock-fontify-region) would return
the new boundaries they used (or nil if they kept the boundaries passed
by jit-lock).


        Stefan




  reply	other threads:[~2009-04-29 20:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 15:34 `font-lock-extend-region-functions' vs. `font-lock-extend-after-change-region-function' Tobias C. Rittweiler
2009-04-28 16:10 ` Stefan Monnier
2009-04-28 20:45   ` Tobias C. Rittweiler
2009-04-29 10:42   ` Tobias C. Rittweiler
2009-04-29 13:46     ` Stefan Monnier
2009-04-29 17:40       ` Tobias C. Rittweiler
2009-04-29 20:26         ` Stefan Monnier [this message]
2009-04-29 20:45           ` Samuel Bronson
2009-04-29 20:53             ` Stefan Monnier
2009-05-01 16:37           ` Tobias C. Rittweiler
2009-05-04 19:08             ` Stefan Monnier
2009-05-07 12:30               ` Tobias C. Rittweiler
2009-05-16 12:26 ` Tobias C. Rittweiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv63gn1a96.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=tcr@freebits.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).