From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: GTK stack-busting loop Date: Sun, 31 Oct 2010 21:28:37 -0400 Message-ID: References: <8739rn810g.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288575027 27551 80.91.229.12 (1 Nov 2010 01:30:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 1 Nov 2010 01:30:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 02:30:23 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PCjE6-0002Z8-HS for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 02:30:22 +0100 Original-Received: from localhost ([127.0.0.1]:34819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCjE5-0001wE-Gk for ged-emacs-devel@m.gmane.org; Sun, 31 Oct 2010 21:30:21 -0400 Original-Received: from [140.186.70.92] (port=59668 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCjCQ-0001NJ-Tm for emacs-devel@gnu.org; Sun, 31 Oct 2010 21:28:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCjCP-0004X4-UY for emacs-devel@gnu.org; Sun, 31 Oct 2010 21:28:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25851 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCjCP-0004X0-Qz for emacs-devel@gnu.org; Sun, 31 Oct 2010 21:28:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AskIAH+0zUxFpZAX/2dsb2JhbACgSXxyuQSFRASSKw X-IronPort-AV: E=Sophos;i="4.58,270,1286164800"; d="scan'208";a="81222072" Original-Received: from 69-165-144-23.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.23]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 31 Oct 2010 21:28:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 09108A8625; Sun, 31 Oct 2010 21:28:37 -0400 (EDT) In-Reply-To: <8739rn810g.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 31 Oct 2010 00:00:31 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132227 Archived-At: > *** src/xterm.c 2010-10-25 16:04:54 +0000 > --- src/xterm.c 2010-10-31 03:51:26 +0000 > *************** > *** 7056,7062 **** > } > --handling_signal; > ! UNBLOCK_INPUT; > return count; > } > --- 7056,7062 ---- > } > --handling_signal; > ! --interrupt_input_blocked; > return count; > } > Any thoughts? (Stefan?) That doesn't sound very good. There's nothing wrong (fundamentally) with the UNBLOCK_INPUT causing another call to XTread_socket: after all, we've basically finished the first call when we get to UNBLOCK_INPUT, so there's no "nested interrupt" problem, AFAICT. After all, we're just coming out of a "while (gtk_events_pending ())", so the case where we get "called recursively" should be very rare. I.e. I think this "problem" can only happen in bogus cases such as with Gtk's bug. Stefan