Re: Should Emacs provide a uuid function?

[Stefan Monnier <monnier@iro.umontreal.ca>]

> I was particularly trying to avoid proliferating the ugliness of the
> kind we have in battery.el:

>   (defcustom battery-status-function
>     (cond ((and (eq system-type 'gnu/linux)
> 		(file-readable-p "/proc/apm"))
> 	   'battery-linux-proc-apm)
> 	  ((and (eq system-type 'gnu/linux)
> 		(file-directory-p "/proc/acpi/battery"))
> 	   'battery-linux-proc-acpi)
> 	  ((and (eq system-type 'gnu/linux)
> 		(file-directory-p "/sys/class/power_supply/")
> 		(directory-files "/sys/class/power_supply/" nil "BAT[0-9]$"))
> 	   'battery-linux-sysfs)
> 	  ((and (eq system-type 'darwin)
> 		(condition-case nil
> 		    (with-temp-buffer
> 		      (and (eq (call-process "pmset" nil t nil "-g" "ps") 0)
> 			   (> (buffer-size) 0)))
> 		  (error nil)))
> 	   'battery-pmset)
> 	  ((eq system-type 'windows-nt)
> 	   'w32-battery-status))

I don't mind this kind of dispatch table, personally.

> I think it would be much cleaner to have 5 different implementations
> in sysdep.c of the same primitive, than have the above followed by 4
> different Lisp functions plus one primitive.

I don't find the dispatch table worse than the sysdep.c
code, personally.


        Stefan