From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Wed, 06 Jul 2011 14:30:10 -0400 Message-ID: References: <201106040034.15598.ruediger@c-plusplus.de> <201106061825.25078.ruediger@c-plusplus.de> <201106240250.01247.ruediger@c-plusplus.de> <4E148534.40106@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309980945 22559 80.91.229.12 (6 Jul 2011 19:35:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2011 19:35:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 06 21:35:38 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QeXso-0007bR-DY for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2011 21:35:38 +0200 Original-Received: from localhost ([::1]:58254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeXsm-0003Xi-LM for ged-emacs-devel@m.gmane.org; Wed, 06 Jul 2011 15:35:36 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:36133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeWrZ-00028z-EW for emacs-devel@gnu.org; Wed, 06 Jul 2011 14:30:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QeWrU-0005js-OM for emacs-devel@gnu.org; Wed, 06 Jul 2011 14:30:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26369 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeWrU-0005je-5d for emacs-devel@gnu.org; Wed, 06 Jul 2011 14:30:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAAupFE5FxIV4/2dsb2JhbABTEKd1eIh6uzmGNwSea4NcUw X-IronPort-AV: E=Sophos;i="4.65,488,1304308800"; d="scan'208";a="120702397" Original-Received: from 69-196-133-120.dsl.teksavvy.com (HELO ceviche.home) ([69.196.133.120]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 06 Jul 2011 14:30:10 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1EA20660D9; Wed, 6 Jul 2011 14:30:10 -0400 (EDT) In-Reply-To: <4E148534.40106@cs.ucla.edu> (Paul Eggert's message of "Wed, 06 Jul 2011 08:54:28 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141672 Archived-At: >> My preference would be to wait for 24.2 since we're in feature freeze, >> but it's the kind of feature which benefits from being available early >> so other packages can start using it. WDYT? > I briefly looked at it for integer-overflow issues, and found one: it > assumes that inotify cookies fit into an Emacs fixnum. Thanks. This needs to be fixed, indeed. > This assumption isn't true on 32-bit hosts, unless Emacs is configured > with --with-wide-int. As you know I'm a fan of wide integers, and my > preferred solution would be to make --with-wide-int the default, which > would solve the problem. No, that would only solve the problem if the --with-wide-int option is removed on 32bit systems and imposed as the only choice. Even if we may change the default for 24.2 we're definitely not going to drop support for "narrow int" operation so soon. Stefan