From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: bug#12022: [PATCH] Unable to use anonymous functions for Key Translations
Date: Tue, 21 Aug 2012 13:40:17 -0400 [thread overview]
Message-ID: <jwv628cm9j9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAFM41H1wagFyBp+dOERvdXk8R7uDUsAp0uCfmRSwRJnepJ4GxA@mail.gmail.com> (Barry OReilly's message of "Fri, 17 Aug 2012 11:05:52 -0400")
> What I'm really doing involves the need for a closure, so I proceeded to
> enable lexical binding. This causes the test case to fail again. I looked
> into it and found that DEFUN("functionp", ...) checks EQ (car, Qclosure)
> but FUNCTIONP does not.
Oops, sounds like a bug.
> We could add the same check to FUNCTIONP, but I'm
> wondering if one of these functions should leverage the other?
Yes. The bulk of Ffunctionp should probably be moved to lisp.h into
a "functionp" inlinable function, then make FUNCTIONP an alias
for functionp and make Ffunctionp use functionp.
Stefan
next prev parent reply other threads:[~2012-08-21 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 15:05 bug#12022: [PATCH] Unable to use anonymous functions for Key Translations Barry OReilly
2012-08-21 17:40 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-14 0:02 Barry OReilly
2012-08-14 12:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv628cm9j9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).