From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113896: Declare external variables. Date: Fri, 16 Aug 2013 12:28:48 -0400 Message-ID: References: <871u5uozq5.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376670558 4812 80.91.229.3 (16 Aug 2013 16:29:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Aug 2013 16:29:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 16 18:29:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VAMtq-0008Lu-TI for ged-emacs-devel@m.gmane.org; Fri, 16 Aug 2013 18:29:19 +0200 Original-Received: from localhost ([::1]:60126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMtq-0006mc-Ce for ged-emacs-devel@m.gmane.org; Fri, 16 Aug 2013 12:29:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMtb-0006Xk-Ch for emacs-devel@gnu.org; Fri, 16 Aug 2013 12:29:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAMtR-0000BJ-35 for emacs-devel@gnu.org; Fri, 16 Aug 2013 12:29:03 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMtQ-0000B3-U7 for emacs-devel@gnu.org; Fri, 16 Aug 2013 12:28:52 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r7GGSmcr014099; Fri, 16 Aug 2013 12:28:48 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 30944B44A4; Fri, 16 Aug 2013 12:28:48 -0400 (EDT) In-Reply-To: <871u5uozq5.fsf@gmx.de> (Michael Albinus's message of "Fri, 16 Aug 2013 09:34:58 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4672=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4672> : streams <1020697> : uri <1508497> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162820 Archived-At: >>> +(eval-when-compile >>> + (defvar directory-sep-char) >>> + (defvar dired-move-to-filename-regexp)) >> You don't want to "eval" those defvars, since evaluating such a defvar is >> mostly a no-op. So don't put them inside eval-when-compile. > But it doesn't hurt, does it? Yes it does. It actually hides those defvars from the compiler since it passes the code to `eval' and only passes the result (aka nil) to the compiler (at least, that's what "eval-when-compile" is supposed to mean). It's a bad habit. The byte-compiler has to do extra work to find those defvars because of people who write code like that. Please fix it, so as not to set a bad example, Stefan