From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate. Date: Thu, 31 Oct 2013 13:55:35 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1383242155 22297 80.91.229.3 (31 Oct 2013 17:55:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Oct 2013 17:55:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 31 18:55:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbwTN-0006RP-5C for ged-emacs-devel@m.gmane.org; Thu, 31 Oct 2013 18:55:57 +0100 Original-Received: from localhost ([::1]:58663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbwTM-00051Z-RH for ged-emacs-devel@m.gmane.org; Thu, 31 Oct 2013 13:55:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbwTA-0004wo-5b for emacs-devel@gnu.org; Thu, 31 Oct 2013 13:55:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbwT2-0004dM-NA for emacs-devel@gnu.org; Thu, 31 Oct 2013 13:55:44 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:29811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbwT2-0004dG-Jb for emacs-devel@gnu.org; Thu, 31 Oct 2013 13:55:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAFABK/CFFsoXfp/2dsb2JhbABEhke4Rxdzgh4BAQQBIzMjBQsJAhoCGA4CAhQYDSSIHgaTYJp/kk6BI45UgRMDpHqBXoMT X-IPAS-Result: AgAFABK/CFFsoXfp/2dsb2JhbABEhke4Rxdzgh4BAQQBIzMjBQsJAhoCGA4CAhQYDSSIHgaTYJp/kk6BI45UgRMDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="36781412" Original-Received: from 108-161-119-233.dsl.teksavvy.com (HELO pastel.home) ([108.161.119.233]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 Oct 2013 13:55:35 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 92FBE611E1; Thu, 31 Oct 2013 13:55:35 -0400 (EDT) In-Reply-To: (Bozhidar Batsov's message of "Thu, 31 Oct 2013 14:40:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164741 Archived-At: > The attached patch simply replaces (set (make-local-variable =E2=80=A6)= =E2=80=A6) with > setq-local=E2=80=99 where appropriate in ruby-mode.el. Is it OK to use such bleeding-edge constructs in ruby-mode.el, or is there still some external version with which we should try to preserve compatibility? I meant, the code still tests (functionp 'syntax-ppss), so if we can drop backward compatibility, there are probably more cleanups ahead. Stefan