unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate.
Date: Thu, 31 Oct 2013 13:55:35 -0400	[thread overview]
Message-ID: <jwv61sdtjju.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CDA4951FEF8347B3BA7A56FA814DAB26@gmail.com> (Bozhidar Batsov's message of "Thu, 31 Oct 2013 14:40:37 +0200")

> The attached patch simply replaces (set (make-local-variable …)…) with
> setq-local’ where appropriate in ruby-mode.el.

Is it OK to use such bleeding-edge constructs in ruby-mode.el, or is
there still some external version with which we should try to preserve
compatibility?

I meant, the code still tests (functionp 'syntax-ppss), so if we can
drop backward compatibility, there are probably more cleanups ahead.


        Stefan



  reply	other threads:[~2013-10-31 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 12:40 [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate Bozhidar Batsov
2013-10-31 17:55 ` Stefan Monnier [this message]
2013-10-31 19:44   ` Bozhidar Batsov
2013-11-01  3:43     ` Dmitry Gutov
2013-11-01 12:26       ` Stefan Monnier
2013-11-02  0:23         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv61sdtjju.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).