From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change c7a6601 1/5: undo-size can count number of boundaries. Date: Thu, 17 Sep 2015 08:53:16 -0400 Message-ID: References: <20150915152129.671.61929@vcs.savannah.gnu.org> <8761395uxx.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442494419 32599 80.91.229.3 (17 Sep 2015 12:53:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2015 12:53:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 17 14:53:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZcYgo-0002ch-T2 for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2015 14:53:27 +0200 Original-Received: from localhost ([::1]:58418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcYgo-0008Fo-AH for ged-emacs-devel@m.gmane.org; Thu, 17 Sep 2015 08:53:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcYgj-0008FT-EB for emacs-devel@gnu.org; Thu, 17 Sep 2015 08:53:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcYgf-0007N9-E0 for emacs-devel@gnu.org; Thu, 17 Sep 2015 08:53:21 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:30624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcYgf-0007Mn-Ae for emacs-devel@gnu.org; Thu, 17 Sep 2015 08:53:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/2yixEVcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0BwsUGA2IWwjPIwEBAQEGAQEBAR6LOoUFB4QtBZA0owuBRSOCO4FZIoJ4AQEB X-IPAS-Result: A0CtCwA731xV/2yixEVcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0BwsUGA2IWwjPIwEBAQEGAQEBAR6LOoUFB4QtBZA0owuBRSOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="165108780" Original-Received: from 69-196-162-108.dsl.teksavvy.com (HELO ceviche.home) ([69.196.162.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Sep 2015 08:53:17 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7B6666619A; Thu, 17 Sep 2015 08:53:16 -0400 (EDT) In-Reply-To: <8761395uxx.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 17 Sep 2015 09:08:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190044 Archived-At: >>> + if(NILP (Vundo_buffer_undoably_changed)){ >>> + Fset (Qundo_buffer_undoably_changed,Qt); >>> + safe_run_hooks (Qundo_first_undoable_change_hook); >>> + } >> Why do you need Vundo_buffer_undoably_changed? >> Doesn't (car-safe buffer-undo-list) give you the same information? > No. The point is that this can be reset when ever I choose, and so it > may well occur *not* after a boundary. But why would you want to set it not after a boundary? > hands of the lisp developer, since they can reset > "buffer-unably-changed" as they want, which will result in a new call > to the hook. When is this needed/useful? > I have chosen not to add a "undoable-change" hook, because I didn't need > it. The first change hook calls rarely, so the performance issues with > handling this change in lisp are, I think, unimportant. Agreed. Stefan