From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Don't complain about changed file when it hasn't changed Date: Tue, 30 Aug 2016 13:16:45 -0400 Message-ID: References: <83oa4bbq5b.fsf@gnu.org> <83a8funuqw.fsf@gnu.org> <83twe2mdpu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472577463 1437 195.159.176.226 (30 Aug 2016 17:17:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Aug 2016 17:17:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 30 19:17:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bemfK-0008Ld-Gr for ged-emacs-devel@m.gmane.org; Tue, 30 Aug 2016 19:17:38 +0200 Original-Received: from localhost ([::1]:50318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bemfI-0004h9-4R for ged-emacs-devel@m.gmane.org; Tue, 30 Aug 2016 13:17:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bemba-0002lp-I1 for emacs-devel@gnu.org; Tue, 30 Aug 2016 13:13:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bembW-0006S0-Bw for emacs-devel@gnu.org; Tue, 30 Aug 2016 13:13:46 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bembW-0006Rc-5T; Tue, 30 Aug 2016 13:13:42 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u7UHDfr6024117; Tue, 30 Aug 2016 13:13:41 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id E9CCD66274; Tue, 30 Aug 2016 13:16:45 -0400 (EDT) In-Reply-To: <83twe2mdpu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Aug 2016 19:19:25 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5782=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5782> : inlines <5157> : streams <1692550> : uri <2278172> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206971 Archived-At: >> > -- Function: ask-user-about-supersession-threat filename >> > This function is used to ask a user how to proceed after an attempt >> > to modify an buffer visiting file FILENAME when the file is newer >> > than the buffer text. Emacs detects this because the modification >> > time of the file on disk is newer than the last save-time of the >> > buffer. This means some other program has probably altered the >> > file. >> >> > Some of that will no longer be accurate once we install your changes. >> >> Hmm... actually, this documentation is still valid, because it specifies >> when the function is called (which is not changed by my patch) rather >> than what the function does. > We are splitting hair. > The problematic place (for me) is the "modification time of the file > on disk is newer", which implies that this is the only test for the > detection of supersession-threat. No, it is the only test made before calling this function (indeed, the function doesn't make any such test). My patch doesn't affect this: the only test performed before calling this function is still the modtime test. It's important to know where the test is performed because: This function is called automatically by Emacs on the proper occasions. It exists so you can customize Emacs by redefining it. See the file @file{userlock.el} for the standard definition. So if you want to "update the doc" here, we'd have to actually state what the standard definition does (we currently don't do actually that). Stefan