From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Wed, 14 Dec 2016 13:15:32 -0500 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> <8ek2b25ubu.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481739356 1791 195.159.176.226 (14 Dec 2016 18:15:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Dec 2016 18:15:56 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 14 19:15:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHE5o-0008Qq-8f for ged-emacs-devel@m.gmane.org; Wed, 14 Dec 2016 19:15:52 +0100 Original-Received: from localhost ([::1]:49465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHE5s-0001aN-It for ged-emacs-devel@m.gmane.org; Wed, 14 Dec 2016 13:15:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHE5l-0001ZP-Vt for emacs-devel@gnu.org; Wed, 14 Dec 2016 13:15:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHE5i-0003hA-6U for emacs-devel@gnu.org; Wed, 14 Dec 2016 13:15:49 -0500 Original-Received: from [195.159.176.226] (port=32773 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHE5h-0003h1-Vd for emacs-devel@gnu.org; Wed, 14 Dec 2016 13:15:46 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cHE5W-000605-Aa for emacs-devel@gnu.org; Wed, 14 Dec 2016 19:15:34 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:czloWWIpI/+gRO713U8d3gIVgkg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210463 Archived-At: > I hear what you're saying. I'm usually not a fan of excessive argument > checking, but this case seemed ok to me. But I don't feel much about > it either way, so if you want to revert it and close the associated > reports as wontfix, that's totally fine by me. The funny thing is that we have a similar arg check in fmakunbound (which I removed in my local Emacs a long time ago), and the OP actually tried to undo his mistake using `fmakunbound` but bumped into that other excessive checking, which prevented him from fixing this first mistake (of course, (fset nil nil) would have worked, but it didn't occur to him). Stefan